[WIP] Linux wait mount#1161
Closed
kivikakk wants to merge 10 commits into
Closed
Conversation
We add the core GVFS.Platform.Linux classes, derived from their GVFS.Platform.Mac equivalents but with appropriate changes for syscall argument signatures and flag values, type definitions, and structure fields (e.g., mode_t is a uint, and the layout of struct stat is quite different). The build tooling is largely a duplicate of the corresponding Mac configuration, with some changes to ensure we build successfully on Linux (e.g., testing for "!= Windows" is no longer sufficient to determine that the platform is OS X). The GVFS.sln configuration changes should ensure that the ProjFS.Linux.Managed and GVFS.Platform.Linux subprojects are built on all platforms (and their Mac and Windows equivalents are built on Linux), and that the GVFS.Service.Mac classes are built on Linux, so as to allow the GVFS.UnitTests subproject to build and run successfully on all three platforms. We also build the GVFS.Hooks.Linux and GVFS.Mount.Linux subprojects on both Linux and Windows, just as their Mac counterparts are built on both Mac and Windows. The GVFS.Service binary is, for the time being, only a stub on Linux, as we have yet to determine how (or if) we should handle auto-mounting repositories. Note that for now the BuildGVFSForLinux.sh script does not perform any installation or packaging. Co-authored-by: Ashe Connor <ashe@kivikakk.ee>
Based on work from commit 4b032fe, from before the full GVFS.Service implementation for macOS.
We treat file modes as a 32-bit uint to match Linux's mode_t.
On Linux, try to use "which" to locate the "gvfs" binary, if possible; otherwise default to the /usr/local/vfsforgit/gvfs path.
These checks allow us to detect compilation on systems which may not meet requirements for stat(2) struct field layout and __xstat64() libc ABI support on Linux.
Spotted by @kivikakk on review! Co-authored-by: Ashe Connor <ashe@kivikakk.ee>
kivikakk
force-pushed
the
linux-wait-mount
branch
4 times, most recently
from
41c9713 to
3b2fd95
Compare
kivikakk
force-pushed
the
linux-wait-mount
branch
from
3b2fd95 to
f82659d
Compare
Contributor
Author
|
github#21 was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running tests for github#21 (for merge into #1125).
/cc @chrisd8088 fyi