Skip to content

build GVFS.Upgrader on Linux#1191

Closed
kivikakk wants to merge 1 commit into
microsoft:features/linuxprototypefrom
github:linux-upgrader-build
Closed

build GVFS.Upgrader on Linux#1191
kivikakk wants to merge 1 commit into
microsoft:features/linuxprototypefrom
github:linux-upgrader-build

Conversation

@kivikakk
Copy link
Copy Markdown
Contributor

@kivikakk kivikakk commented May 23, 2019

Build GVFS.Upgrader on Linux. Fixes the following build errors:

Upgrader/UpgradeOrchestratorTests.cs(35,17): error CS0246: The type or namespace name 'UpgradeOrchestrator' could not be found (are you missing a using directive or an assembly reference?) [/home/kivikakk/microsoft/VFSForGit/GVFS/GVFS.UnitTests/GVFS.UnitTests.csproj]
Upgrader/UpgradeOrchestratorWithGitHubUpgraderTests.cs(13,17): error CS0246: The type or namespace name 'UpgradeOrchestrator' could not be found (are you missing a using directive or an assembly reference?) [/home/kivikakk/microsoft/VFSForGit/GVFS/GVFS.UnitTests/GVFS.UnitTests.csproj]

Also include the Linux platform loader in GVFS.Upgrader.

See #1059 for some vaguely related prior work.

/cc @chrisd8088 fyi
/cc @derrickstolee @wilbaker

@chrisd8088
Copy link
Copy Markdown
Contributor

@kivikakk -- might this go better into our linux-gvfs-provider branch? I don't think there are any Linux-related changes to GVFS.sln or any of the GVFS classes in features/linuxprototype yet; they're all in linux-gvfs-provider.

@kivikakk
Copy link
Copy Markdown
Contributor Author

Ah, yes, you're quite right! Thanks for the pick up.

@kivikakk kivikakk closed this May 24, 2019
@kivikakk kivikakk deleted the linux-upgrader-build branch May 24, 2019 00:57
@kivikakk
Copy link
Copy Markdown
Contributor Author

Already there as e7f64cf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants