Upgrader: add command install action#1230
Merged
jamill merged 3 commits intoJun 13, 2019
Merged
Conversation
jamill
force-pushed
the
upgrader_tasks/installer_command
branch
from
95a4b02 to
1e8b6cb
Compare
mjcheetham
reviewed
Jun 3, 2019
jamill
force-pushed
the
upgrader_tasks/installer_command
branch
2 times, most recently
from
0094c2e to
314af17
Compare
Contributor
Could you please update the description with a few additional details.
|
jamill
force-pushed
the
upgrader_tasks/installer_command
branch
from
314af17 to
3a16a8e
Compare
Member
Author
|
@alameenshah Thanks for the review! I updated the description to address the (good) questions you brought up. |
kewillford
suggested changes
Jun 11, 2019
Member
kewillford
left a comment
kewillford
left a comment
There was a problem hiding this comment.
This looks good to me. My only question is about any security issues.
kewillford
approved these changes
Jun 11, 2019
Member
kewillford
left a comment
kewillford
left a comment
There was a problem hiding this comment.
This looks good to me and thanks for the explanations.
When running install actions, we previously only supported starting an application or document contained in the installer package. You might want to run instead a command that is provided by the host operating system / environment. For example, on macOS you might want to run bash or the "installer" binary directly.
jamill
force-pushed
the
upgrader_tasks/installer_command
branch
from
3a16a8e to
5b2c3aa
Compare
replacementToken method should be PascalCase
jamill
force-pushed
the
upgrader_tasks/installer_command
branch
from
5b2c3aa to
6aba70f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the upgrader runs install actions defined in the installer manifest, it previously only supported starting an application or document contained in the installer package. The installer author might
want to run instead a command that is provided by the host operating
system / environment. For example, on macOS the installer author might want to run bash
or the "installer" binary directly as one of the install actions defined in the installer payload.
As any command can be included as an installer action, there is not any additional verification we can make about the command, except for validating the integrity of the containing NuGet package, and enforcing that the package contents have not been tampered with before we run the command.
This does not currently include a mechanism to define an environment variable.