Speccpu Compiler Check fix for Windows #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangpanMS
reviewed
Mar 10, 2025
src/VirtualClient/VirtualClient.Actions/SPECcpu/SpecCpuExecutor.cs
Outdated
Show resolved
Hide resolved
yangpanMS
reviewed
Mar 12, 2025
src/VirtualClient/VirtualClient.Actions/SPECcpu/SpecCpuExecutor.cs
Outdated
Show resolved
Hide resolved
added 2 commits
March 12, 2025 11:35
…n for CompilerInstallation in windows.
yangpanMS
approved these changes
Mar 13, 2025
Contributor
yangpanMS
left a comment
yangpanMS
left a comment
There was a problem hiding this comment.
Approved but please confirm it works on Windows, and also linux both gcc9 and gcc10
yangpanMS
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc check needs its full path to run on Windows terminal.
Fix: Retrieve and use the cygwinInstallationPath environment variable.