Add Elasticsearch Rally workload artifacts #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: v-safilho <v-safilho@microsoft.com>
…ticsearch package download. New profile parameters to let the user choose Elasticsearch and Rally versions. Implemented the control to let wget or apt to be used for Linux, and WebRequest or parallel download for Windows. New unit tests were built.
…ps://github.com/v-safilho/VirtualClient into users/v-safilho/Add-ElasticsearchRally-Workload
…ps://github.com/v-safilho/VirtualClient into users/v-safilho/Add-ElasticsearchRally-Workload
saibulusu
reviewed
Jan 17, 2026
| using global::VirtualClient.Contracts; | ||
| using Microsoft.VisualBasic; | ||
|
|
||
| internal class ElasticsearchMetricReader |
Member
There was a problem hiding this comment.
This looks like it should be a metrics parser, for our other workloads we extend from the MetricsParser abstract class. It seems to do what you're doing here with this reader.
| using System.Threading; | ||
| using System.Threading.Tasks; | ||
|
|
||
| internal class ParallelDownloadHandler |
Member
There was a problem hiding this comment.
This seems generic and not related to elastic search/rally? I think VirtualClient.Core or VirtualClient.Dependencies might be a better place for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Linux client/server workload to evaluate hardware performance using Elasticsearch.
related to PBI #28841299