Saving INF as text file to avoid CRLF issues.#10
Closed
bhouse-microsoft wants to merge 1 commit into
Closed
Conversation
Author
|
There is another way to deal with this problem by introducing a local .gitattributes file. I'll suggest that instead given that these files are being replicated from SD. |
5an7y-Microsoft
pushed a commit
that referenced
this pull request
Aug 11, 2025
Selected path bug fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The INF file was saved as a UTF-16 file which GIT will see as binary for the most part. However, we have specified that all INF files are text that should have CRLF conversions in the repository .gitattributes file. When we clone the respository, the CRLF conversions are still being done to the UTF-16 INF file(s) causing them to become mangled. Building the sample fails as the INF essentially appears to be a corrupted file.
This change converts the INF file back to a pure ANSI unmangled text file.
All other UTF-16 INF files in the upstream repository should also be fixed.