Skip to content

Network: Removed trailing spaces#1384

Open
andremueiot wants to merge 2 commits into
microsoft:mainfrom
andremueiot:user/andremueiot/trailing_spaces
Open

Network: Removed trailing spaces#1384
andremueiot wants to merge 2 commits into
microsoft:mainfrom
andremueiot:user/andremueiot/trailing_spaces

Conversation

@andremueiot
Copy link
Copy Markdown

@andremueiot andremueiot commented May 15, 2026

Removed trailing spaces from files under "network" to reduce noise when making changes using AI so that future reviews are easier to be done by humans.
No functional code changes—only whitespace at the end of lines were removed.
Side effect: These changes saved about of 60 KB of space.

@andremueiot andremueiot marked this pull request as ready for review May 15, 2026 18:29
@andremueiot andremueiot requested review from a team as code owners May 15, 2026 18:29
Copy link
Copy Markdown
Member

@keith-horton keith-horton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found all the non-space changes?
It's very hard to review to catch these given the sheer number of files modified :(

Comment thread network/trans/ddproxy/sys/DD_drv.c
Comment thread network/trans/inspect/sys/TL_drv.c
Comment thread network/trans/inspect/sys/TL_drv.c
Comment thread network/trans/WFPSampler/exe/HelperFunctions_CommandLine.cpp
Comment thread network/wlan/WDI/COMMON/SecurityGen.h
Comment thread network/wlan/WDI/HAL/phydm/development_note2012.txt
Comment thread network/wlan/WDI/HAL/phydm/rtchnlplan.h Outdated
Comment thread network/wlan/WDI/PLATFORM/NDIS6/WDI_Xlat.c
Comment thread network/wlan/WDI/PLATFORM/NdisComm/NdisOid.c
Comment thread network/wlan/WDI/PLATFORM/NdisComm/NdisOid.c
@andremueiot
Copy link
Copy Markdown
Author

I think I found all the non-space changes? It's very hard to review to catch these given the sheer number of files modified :(

I was also surprised by the number of changes. It's good that AI does not complain about the amount of work.
I'll address most of your comments in a subsequent PR, so that we can restrict this PR to trailing spaces removal. That gives me peace of mind that no regression is introduced here and missed during review.

@keith-horton keith-horton dismissed their stale review May 15, 2026 22:22

removing my block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants