[dotnet-port-fixes] Align skill asset blocks with .NET - #394
Conversation
Port the .NET skill content behavior that emits explicit available resources and scripts blocks for file-based skills. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR aligns the Go file-based skill content emission with the .NET behavior by always appending authoritative asset inventory blocks to loaded SKILL.md content. It ensures consumers (including LLM prompts) consistently see explicit <available_resources> and <available_scripts> blocks, including explicit empty self-closing blocks when no assets are present.
Changes:
- Append
<available_resources>and<available_scripts>blocks to file-based skill content, emitting explicit empty blocks when lists are empty. - Represent script schemas under
<available_scripts>with nested<parameters_schema>elements (replacing the prior<script_schemas>shape). - Update/extend tests to validate the new block shapes and the explicit empty-block behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| agent/skills/fsskills/source.go | Appends new available-resources/scripts blocks to file skill content and implements the new XML block builders. |
| agent/skills/fsskills/source_script_test.go | Updates script-content expectations to the new <available_scripts> / <parameters_schema> structure and validates empty resources block presence. |
| agent/skills/fsskills/source_test.go | Adds coverage that file-based skill content includes explicit empty/non-empty <available_resources> blocks. |
| agent/skills/skills.go | Updates Script.ParametersSchema doc comment to reflect the new <available_scripts> emission location. |
| agent/skills/skills_test.go | Updates load_skill tool content expectation to include explicit empty available resources/scripts blocks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Generated by Go API Consistency Review Agent for #394 · 409.4 AIC · ⌖ 13.2 AIC · ⊞ 27.1K
|
@copilot address the PR feedback |
…rity Co-authored-by: michelle-clayton-work <262183035+michelle-clayton-work@users.noreply.github.com>
Done — both parity gaps are now fixed in commit
|
Cross-repo Parity Review ✅This PR improves cross-language parity — no consistency issues found. The previous Go implementation used a divergent
The Go changes to
|
Port the .NET skill content behavior that emits explicit available resources and scripts blocks for file-based skills.