Python: updated docstrings - #1225
Merged
eavanvalkenburg merged 4 commits intoOct 6, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates Python docstring formatting to standardize the use of "Keyword Args" sections for named parameters while maintaining "Args" for positional parameters. The changes also include minor fixes to a documentation generation script and some function call improvements.
- Updated docstring formatting across multiple Python files to distinguish between "Args" and "Keyword Args" sections
- Fixed function calls to use proper keyword arguments syntax
- Updated documentation generation script configuration
Reviewed Changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| _provider.py (redis) | Updated docstring formatting to use "Keyword Args" for named parameters |
| _chat_message_store.py (redis) | Standardized docstring format with "Keyword Args" sections |
| _provider.py (mem0) | Updated docstring to use "Keyword Args" for named parameters |
| _sliding_window.py (lab/tau2) | Removed incorrect Args section from docstring |
| _shared.py (openai) | Updated constructor docstring to use "Keyword Args" |
| _exceptions.py (openai) | Cleaned up docstring parameter descriptions |
| observability.py | Updated docstring formatting and removed incorrect parameter |
| _shared.py (azure) | Added "Keyword Args" section to docstring |
| _entra_id_authentication.py (azure) | Standardized docstring format with "Keyword Args" |
| _chat_client.py (azure) | Updated constructor docstring format |
| _workflow_executor.py (workflows) | Added "Keyword Args" section to constructor |
| _validation.py (workflows) | Updated validation function docstrings |
| _magentic.py (workflows) | Standardized docstring format |
| _executor.py (workflows) | Updated executor docstring formatting |
| _agent.py (workflows) | Standardized docstring format across methods |
| _types.py | Extensive docstring updates including format changes and content improvements |
| _tools.py | Updated docstring formatting and fixed function call syntax |
| _threads.py | Standardized docstring format with "Keyword Args" sections |
| _serialization.py | Updated docstring formatting and fixed typo |
| _middleware.py | Added import, updated function calls, and improved docstring |
| _memory.py | Standardized docstring format |
| _mcp.py | Updated docstring formatting across MCP-related classes |
| _clients.py | Extensive docstring formatting updates |
| _agents.py | Updated agent class docstring formatting |
| _agent.py (copilotstudio) | Standardized docstring format |
| _acquire_token.py (copilotstudio) | Updated function signature and docstring |
| _agent.py (a2a) | Standardized docstring format |
| generate_docs.py | Updated documentation generation configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
victordibia
approved these changes
Oct 6, 2025
eavanvalkenburg
force-pushed
the
docstring_updates
branch
from
October 6, 2025 14:23
103984f to
bfc0904
Compare
eavanvalkenburg
force-pushed
the
docstring_updates
branch
from
October 6, 2025 14:44
b69dbcf to
b6156d5
Compare
ekzhu
approved these changes
Oct 6, 2025
ReubenBond
pushed a commit
to ReubenBond/agent-framework
that referenced
this pull request
Oct 28, 2025
* updated docstrings * fix tests and mypy * hosted file search docstring update * updated versions
arisng
pushed a commit
to arisng/agent-framework
that referenced
this pull request
Feb 2, 2026
* updated docstrings * fix tests and mypy * hosted file search docstring update * updated versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Another round of updates to docstrings, and some fixes to the generation script, we should be able to get rid of that part soon.
Description
Contribution Checklist