Skip to content

Python: fix DevUI deployment Dockerfile auth args - #6150

Merged
eavanvalkenburg merged 2 commits into
microsoft:mainfrom
fallintoplace:fix/devui-dockerfile-auth
Jul 8, 2026
Merged

Python: fix DevUI deployment Dockerfile auth args#6150
eavanvalkenburg merged 2 commits into
microsoft:mainfrom
fallintoplace:fix/devui-dockerfile-auth

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

Fix the DevUI deployment Dockerfile generator to stop emitting the removed --auth CLI flag.

Why

DevUI auth is enabled by default now, and non-loopback binds are configured with DEVUI_AUTH_TOKEN or --auth-token.
The generated Dockerfile was still launching devui with --auth, which is parsed as an abbreviated --auth-token and causes startup to fail because no token value is provided.

What changed

  • remove --auth from the generated DevUI Dockerfile command
  • add a regression test covering the generated CMD line
  • assert the Dockerfile does not inline DEVUI_AUTH_TOKEN

Validation

  • uv run --group dev pytest packages/devui/tests/devui/test_deployment.py
  • uv run --group dev ruff check packages/devui/agent_framework_devui/_deployment.py packages/devui/tests/devui/test_deployment.py
  • uv run --group dev ruff format --check packages/devui/agent_framework_devui/_deployment.py packages/devui/tests/devui/test_deployment.py

Copilot AI review requested due to automatic review settings May 28, 2026 13:02
@moonbox3 moonbox3 added the python Usage: [Issues, PRs], Target: Python label May 28, 2026
@fallintoplace

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@fallintoplace
fallintoplace marked this pull request as ready for review May 28, 2026 13:09
@eavanvalkenburg
eavanvalkenburg enabled auto-merge July 8, 2026 08:00
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL44415533887% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python Unit Test Overview

Tests Skipped Failures Errors Time
8798 33 💤 0 ❌ 0 🔥 2m 17s ⏱️

@eavanvalkenburg
eavanvalkenburg added this pull request to the merge queue Jul 8, 2026
Merged via the queue into microsoft:main with commit 339bbeb Jul 8, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Usage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants