-
Notifications
You must be signed in to change notification settings - Fork 1.9k
.NET: Make GitHub.Copilot.SDK build targets reach transitive consumers (#6455) #6457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
westey-m
merged 2 commits into
microsoft:main
from
tamirdresher:tamirdresher/issue-6455-buildtransitive-copilot-sdk
Jun 10, 2026
+85
−0
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
dotnet/src/Microsoft.Agents.AI.GitHub.Copilot/buildTransitive/.gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Auto-generated at pack time by _GenerateBuildTransitiveProps in the csproj. | ||
| Microsoft.Agents.AI.GitHub.Copilot.props | ||
|
|
34 changes: 34 additions & 0 deletions
34
...osoft.Agents.AI.GitHub.Copilot/buildTransitive/Microsoft.Agents.AI.GitHub.Copilot.targets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| <Project> | ||
| <!-- | ||
| Bridge GitHub.Copilot.SDK's build/ targets to transitive consumers. | ||
|
|
||
| GitHub.Copilot.SDK ships its CLI download / binary-copy MSBuild targets under | ||
| build/, which means they only auto-import for projects with a DIRECT | ||
| PackageReference to GitHub.Copilot.SDK. Consumers of this package | ||
| (Microsoft.Agents.AI.GitHub.Copilot) would otherwise get only the managed | ||
| adapter .dll, no copilot CLI binary in their output, and the SDK would fail | ||
| at runtime with: | ||
|
|
||
| Copilot CLI not found at 'bin/{config}/{tfm}/runtimes/{rid}/native/copilot.exe' | ||
|
|
||
| This file ships under buildTransitive/ so NuGet auto-imports it for every | ||
| transitive consumer, locates the SDK in the NuGet package cache, and imports | ||
| the SDK's build/ targets so the CLI binary gets downloaded and copied to the | ||
| consumer's output as expected. | ||
|
|
||
| The companion .props file is generated at this package's pack time and sets | ||
| $(_MicrosoftAgentsAICopilotSdkPackagedVersion) to the SDK version this | ||
| package was built against. The Condition below uses that as the default for | ||
| $(_MicrosoftAgentsAICopilotSdkVersion), so consumers may override the SDK | ||
| version path by setting $(_MicrosoftAgentsAICopilotSdkVersion) before this | ||
| file is imported. Consumers may also opt out of the binary download via the | ||
| SDK's own $(CopilotSkipCliDownload)=true, which the SDK targets honor. | ||
| --> | ||
| <PropertyGroup> | ||
| <_MicrosoftAgentsAICopilotSdkVersion Condition="'$(_MicrosoftAgentsAICopilotSdkVersion)' == ''">$(_MicrosoftAgentsAICopilotSdkPackagedVersion)</_MicrosoftAgentsAICopilotSdkVersion> | ||
| <_MicrosoftAgentsAICopilotSdkTargetsPath Condition="'$(_MicrosoftAgentsAICopilotSdkVersion)' != ''">$([System.IO.Path]::Combine('$(NuGetPackageRoot)', 'github.copilot.sdk', '$(_MicrosoftAgentsAICopilotSdkVersion)', 'build', 'GitHub.Copilot.SDK.targets'))</_MicrosoftAgentsAICopilotSdkTargetsPath> | ||
| </PropertyGroup> | ||
|
|
||
| <Import Project="$(_MicrosoftAgentsAICopilotSdkTargetsPath)" | ||
| Condition="'$(_MicrosoftAgentsAICopilotSdkTargetsPath)' != '' And Exists('$(_MicrosoftAgentsAICopilotSdkTargetsPath)')" /> | ||
| </Project> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.