Add ADR 0029: Skills over MCP implementation design options - #6679
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds a new ADR (0029) documenting implementation design options for “Skills over MCP” features from SEP-2640—specifically MCP resource template skills and direct skill:// references—while explicitly deferring final decisions pending spec and demand clarity.
Changes:
- Introduces ADR-0029 describing MCP resource template skill discovery/resolution flows and implementation options.
- Documents design options for supporting direct
skill://references (function surface, origin routing, and opt-in behavior). - Captures open questions and a postponed decision outcome for both parts.
There was a problem hiding this comment.
Automated Code Review
Reviewers: 5 | Confidence: 83%
✓ Correctness
The ADR document is well-structured and technically sound, but the frontmatter
status: acceptedcontradicts the Decision Outcome section where all three decisions are explicitly marked as 'Postponed' and the introduction states 'The decisions are not yet finalized.' Per the repository's ADR conventions (README says status must initially beproposedand changes toacceptedonce the decision is agreed), this should usestatus: proposed.
✓ Security Reliability
This PR adds ADR 0029, a pure documentation file exploring design options for MCP resource template skills and direct skill references. It contains no executable code, configuration changes, secrets, or modifications to trust boundaries. There are no security or reliability issues to report.
✓ Test Coverage
This PR adds only an ADR document (docs/decisions/0029-mcp-skill-templates-and-direct-references.md) exploring design options for future features. There are no code changes — no new classes, methods, or behavioral modifications — so there is nothing that requires test coverage. All decisions are explicitly postponed pending spec finalization and ecosystem demand.
✓ Failure Modes
This PR adds ADR 0029, a pure documentation/design document exploring implementation options for MCP resource template skills and direct skill references. It contains no executable code changes — only markdown with illustrative API sketches. There are no failure modes, silent failures, or operational concerns to flag.
✓ Design Approach
I did not find a design-approach issue in this ADR that clears the required evidence bar. The document is explicit that the concrete implementation decisions are being postponed, and within that scope the options, tradeoffs, and open questions are documented consistently with the repo’s ADR guidance.
Automated review by SergeyMenshykh's agents
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Adds ADR 0029 exploring design options for two SEP-2640 features: MCP resource template skills and direct skill references. Decisions are currently postponed pending the skills-over-MCP spec release and ecosystem demand.
Closes: #6358
Related: