Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,8 @@ protected override async ValueTask<AIContext> InvokingCoreAsync(InvokingContext

ChatClientAgentSession? chatClientSession = session.GetService<ChatClientAgentSession>();
if (chatClientSession is not null &&
!string.IsNullOrWhiteSpace(chatClientSession.ConversationId))
!string.IsNullOrWhiteSpace(chatClientSession.ConversationId) &&
chatClientSession.ConversationId != PerServiceCallChatHistoryPersistingChatClient.LocalHistoryConversationId)
{
logger.LogCompactionProviderSkipped("session managed by remote service");
return context.AIContext;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,66 @@ public async Task InvokingAsyncAppliesCompactionWhenTriggeredAsync()
Assert.True(resultList.Count < messages.Count);
}

[Fact]
public async Task InvokingAsyncDoesNotSkipCompactionForLocalHistorySentinelAsync()
{
// Arrange
TruncationCompactionStrategy strategy = new(CompactionTriggers.Always, minimumPreservedGroups: 1);
CompactionProvider provider = new(strategy);

Mock<AIAgent> mockAgent = new() { CallBase = true };
ChatClientAgentSession session = new()
{
ConversationId = PerServiceCallChatHistoryPersistingChatClient.LocalHistoryConversationId,
};
List<ChatMessage> messages =
[
new ChatMessage(ChatRole.User, "Q1"),
new ChatMessage(ChatRole.Assistant, "A1"),
new ChatMessage(ChatRole.User, "Q2"),
];

AIContextProvider.InvokingContext context = new(
mockAgent.Object,
session,
new AIContext { Messages = messages });

// Act
AIContext result = await provider.InvokingAsync(context);

// Assert
Assert.NotNull(result.Messages);
Assert.Single(result.Messages);
}

[Fact]
public async Task InvokingAsyncSkipsCompactionForRealServiceConversationIdAsync()
{
// Arrange
TruncationCompactionStrategy strategy = new(CompactionTriggers.Always, minimumPreservedGroups: 1);
CompactionProvider provider = new(strategy);

Mock<AIAgent> mockAgent = new() { CallBase = true };
ChatClientAgentSession session = new() { ConversationId = "service-conversation-id" };
List<ChatMessage> messages =
[
new ChatMessage(ChatRole.User, "Q1"),
new ChatMessage(ChatRole.Assistant, "A1"),
new ChatMessage(ChatRole.User, "Q2"),
];

AIContextProvider.InvokingContext context = new(
mockAgent.Object,
session,
new AIContext { Messages = messages });

// Act
AIContext result = await provider.InvokingAsync(context);

// Assert
Assert.Same(messages, result.Messages);
}

[Fact]
public async Task InvokingAsyncNoCompactionNeededReturnsOriginalMessagesAsync()
{
Expand Down
Loading