fix(neo4j): use variable-scoped CALL subquery in :Node backfill (drop deprecation)#22
Merged
Merged
Conversation
… deprecation)
The :Node backfill in ensure_neo4j_schema used the importing-WITH subquery form
`CALL { WITH n SET n:Node } IN TRANSACTIONS`, which Neo4j 5 deprecates — it emits an
01N00 "CALL subquery without a variable scope clause is deprecated" notification on every
backfill run. Switched to the variable-scoped form `CALL (n) { SET n:Node } IN TRANSACTIONS`.
Behavior identical; deprecation notification gone.
Verified: tests/neo4j migration + node-index-seek tests 6 passed, deprecation notification
no longer emitted, ruff clean.
🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier)
Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
:Nodebackfill inensure_neo4j_schemaused the importing-WITHsubquery formCALL { WITH n SET n:Node } IN TRANSACTIONS, which Neo4j 5 deprecates — it emits an01N00"CALL subquery without a variable scope clause is deprecated" notification on every backfill run (observed on v4.0.2 schema init). Switched to the variable-scoped formCALL (n) { SET n:Node } IN TRANSACTIONS. Behavior is identical; the deprecation notification is gone.Change
context_intelligence_server/neo4j_store.py— backfill query:Evidence
tests/neo4j/test_node_identity_migration.py+tests/neo4j/test_node_index_seek.py: 6 passed (the migration test drives the backfill).01N00CALL-scope deprecation notification no longer appears when the backfill runs (0 occurrences in test output; was emitted on every schema init prior).ruffclean.