No destroy cancellation none#26
Merged
syntheticmagus merged 2 commits intomicrosoft:masterfrom Oct 26, 2020
Merged
Conversation
bghgary
approved these changes
Oct 26, 2020
This was referenced Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses a problem we were encountering in Babylon Native where
cancellation::nonewas getting torn down by one thread while another thread still needed it to exist. A proposal, referenced in a comment in the code, exists to standardize a mechanism for handling this type of error:http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1247r0.html
However, since this proposal is not yet standard, I instead adopted one of the alternatives listed in the proposal to resolve this problem for now. This change has been tested and confirmed to solve the problem Babylon Native was exhibiting.