Skip to content

[docs] Document playwrightCliVersion strict SemVer 2.0 format requirement#1265

Open
aspire-repo-bot[bot] wants to merge 1 commit into
release/13.5from
docs/playwright-cli-version-validation-18205-5de0731eed9add0c
Open

[docs] Document playwrightCliVersion strict SemVer 2.0 format requirement#1265
aspire-repo-bot[bot] wants to merge 1 commit into
release/13.5from
docs/playwright-cli-version-validation-18205-5de0731eed9add0c

Conversation

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Documents changes from microsoft/aspire#18205 by @mitchdenny.

Targeting release/13.5 — the latest release branch on microsoft/aspire.dev — because release/13.4 (derived from the source PR base ref release/13.4) does not exist there.

Why this PR is needed

PR microsoft/aspire#18205 added strict SemVer 2.0 validation to the playwrightCliVersion configuration override in the Playwright CLI installer. Previously, any string value — including npm dist-tags (latest), version ranges (>=1.0.0), or prefixed versions (v1.52.0) — was forwarded directly to npm. Starting with this fix, values that are not valid MAJOR.MINOR.PATCH SemVer strings are rejected with a descriptive error message. The playwrightCliVersion configuration key was previously undocumented; this PR adds the reference that users need to understand both the setting and its format constraint.

Changes

Added a new "Pin the Playwright CLI version" section to src/frontend/src/content/docs/get-started/aspire-skills.mdx:

  • Explains how to set playwrightCliVersion in aspire.config.json or via aspire config set
  • Documents that the value must be strict SemVer 2.0 (MAJOR.MINOR.PATCH)
  • Shows the exact error message users will see for invalid values
  • Instructs users to correct the value and re-run aspire agent init

Files modified

  • src/frontend/src/content/docs/get-started/aspire-skills.mdx — updated (new section added)

Generated by PR Documentation Check for issue #18205 · ● 27.7M ·

Document the playwrightCliVersion configuration setting and its strict
SemVer 2.0 requirement, introduced in microsoft/aspire#18205.

The Playwright CLI installer now validates that playwrightCliVersion
contains a MAJOR.MINOR.PATCH version string before forwarding it to npm.
Dist-tags (latest), ranges (>=1.0.0), and v-prefixed forms (v1.52.0)
are all rejected with a descriptive error message.

Add a 'Pin the Playwright CLI version' section to aspire-skills.mdx
covering the configuration key, valid format, and the new error message
users may see if their config value does not pass validation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@aspire-repo-bot aspire-repo-bot Bot added the docs-from-code Copilot initiated issue from dotnet/aspire repo label Jun 16, 2026
@aspire-repo-bot aspire-repo-bot Bot requested a review from JamesNK June 16, 2026 18:34
@aspire-repo-bot

Copy link
Copy Markdown
Contributor Author

Frontend HTML artifact ready

The latest frontend build uploaded the frontend-dist artifact for PR #1265. Use the VS Code button below to open this PR with GitHub Artifacts Explorer and browse the built HTML locally.

VS Code: Open PR #1265 artifacts

This comment updates automatically when a new frontend build artifact is uploaded.

@IEvangelist IEvangelist marked this pull request as ready for review June 26, 2026 15:13
@IEvangelist IEvangelist self-requested a review as a code owner June 26, 2026 15:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documents the newly enforced strict SemVer (MAJOR.MINOR.PATCH) requirement for the playwrightCliVersion override used by aspire agent init, so users understand how to pin Playwright CLI versions and what error they’ll see for invalid values.

Changes:

  • Adds a “Pin the Playwright CLI version” section describing playwrightCliVersion usage in aspire.config.json.
  • Adds an equivalent aspire config set example.
  • Documents the strict MAJOR.MINOR.PATCH constraint and includes the expected validation error message.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@IEvangelist

Copy link
Copy Markdown
Member

[docs-from-code-ci-note] CI has been retriggered multiple times and is still failing due to the current PR changes (not a transient runner issue). Please update the PR changes to fix the failing checks.

@IEvangelist

Copy link
Copy Markdown
Member

We've retriggered CI multiple times, and the current failures appear tied to changes in this PR rather than a transient pipeline issue. This likely needs a fix in the PR branch before CI will pass.

@IEvangelist

Copy link
Copy Markdown
Member

We've retriggered CI several times, and the current failures appear to be caused by changes in this PR rather than a transient runner issue. This likely needs updates in the PR content/code to get green checks.

@IEvangelist

Copy link
Copy Markdown
Member

[docs-from-code-ci] CI has been retriggered multiple times and is still failing. This appears to be due to the current PR changes rather than a transient infrastructure issue.

@IEvangelist

Copy link
Copy Markdown
Member

CI has been retriggered multiple times and is still failing for this PR (latest failures: 'CI' (attempt 8)). This likely needs changes in the PR itself rather than another rerun.

@IEvangelist

Copy link
Copy Markdown
Member

This PR has had CI retriggered multiple times and is still failing on PR-specific checks. It likely needs a change in this PR to pass.

@IEvangelist

Copy link
Copy Markdown
Member

[docs-from-code automation] repeated-rerun-note
CI has been retriggered multiple times and is still failing on this PR. This now looks likely to be caused by the PR changes rather than transient CI flakiness; it probably needs a content/code fix in this branch.

@IEvangelist

Copy link
Copy Markdown
Member

We've retriggered CI many times on this PR and it's still failing. At this point, the failure likely comes from changes in this PR rather than transient CI flakiness, so this probably needs a content/code fix in the PR itself.

@IEvangelist

Copy link
Copy Markdown
Member

CI has failed repeatedly on this docs-from-code PR after multiple reruns, and the failures appear to be related to the changes in this PR. Please review and adjust the PR content so the checks can pass.

@IEvangelist

Copy link
Copy Markdown
Member

CI has been retriggered multiple times on this PR and is still failing. The failures appear tied to the current PR changes rather than a transient runner issue, so this likely needs an update in the PR content before CI will pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-from-code Copilot initiated issue from dotnet/aspire repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants