Skip to content

[docs] Add OS information check to aspire doctor docs#1267

Open
aspire-repo-bot[bot] wants to merge 1 commit into
release/13.5from
docs-aspire-18252-os-doctor-6830cd8abec29e2f
Open

[docs] Add OS information check to aspire doctor docs#1267
aspire-repo-bot[bot] wants to merge 1 commit into
release/13.5from
docs-aspire-18252-os-doctor-6830cd8abec29e2f

Conversation

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Documents changes from microsoft/aspire#18252, authored by @danegsta.

Targeting release/13.5 based on the source PR milestone 13.5 (exact match on microsoft/aspire.dev).

Why this PR is needed

microsoft/aspire#18252 adds a new Operating system environment check to the aspire doctor command. The check is always present and surfaces OS details in both human-readable table output and JSON output, including a structured metadata payload useful for tooling. The existing aspire-doctor.mdx reference page needed updates to reflect this new check.

Triggered signals

  • cli_resource_strings_changed: src/Aspire.Cli/Resources/DoctorCommandStrings.resx was modified, adding the OperatingSystemMessageFormat resource string ("Operating system: {0}").
  • pr_body_has_user_facing_section: The PR body contains a ### User-facing usage heading with sample table and JSON output.
  • pr_body_has_cli_flag_mention: The PR body references --format json in the validation instructions.

What changed

src/frontend/src/content/docs/reference/cli/commands/aspire-doctor.mdx

  • Updated the Environment checks description bullet to mention OS reporting (type, version, and Linux distro details from /etc/os-release).
  • Updated the sample table output to show ✅ Operating system: macOS 15.5.0 in the Environment section and bumped the summary count from 5 to 6.
  • Added the operating-system check entry to the JSON output example with all four metadata fields (osType, displayName, version, description).
  • Added a reference table documenting the four metadata fields and their sources per platform.

Additional update needed

The aspire-13-5.mdx What's New page also needs a bullet in the CLI improvements and diagnostics section. Please add the following before the "Embedded Aspire skills bundle fallback" bullet:

OS information in aspire doctor: The aspire doctor command now reports operating system details in its Environment section. Human-readable output shows the OS type and version (for example, ✅ Operating system: macOS 15.5.0); on Linux it includes the distro name from /etc/os-release. JSON output adds a structured operating-system check with osType, displayName, version, and description metadata fields for tooling consumption.

Files modified

  • src/frontend/src/content/docs/reference/cli/commands/aspire-doctor.mdx (updated)

Generated by PR Documentation Check for issue #18252 · 1.8K AIC · ⌖ 19.4 AIC · ⊞ 45.4K ·

Add documentation for the new operating system check introduced in
microsoft/aspire#18252. The check appears in the Environment section
of `aspire doctor` output and includes structured metadata in JSON
format.

Changes:
- Update Environment checks description to mention OS reporting
- Add OS check to sample table output
- Add operating-system entry to JSON output example
- Document the osType/displayName/version/description metadata fields

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@aspire-repo-bot aspire-repo-bot Bot added the docs-from-code Copilot initiated issue from dotnet/aspire repo label Jun 17, 2026
@aspire-repo-bot aspire-repo-bot Bot requested a review from JamesNK June 17, 2026 03:19
@aspire-repo-bot

Copy link
Copy Markdown
Contributor Author

Frontend HTML artifact ready

The latest frontend build uploaded the frontend-dist artifact for PR #1267. Use the VS Code button below to open this PR with GitHub Artifacts Explorer and browse the built HTML locally.

VS Code: Open PR #1267 artifacts

This comment updates automatically when a new frontend build artifact is uploaded.

@IEvangelist IEvangelist marked this pull request as ready for review June 26, 2026 15:13
@IEvangelist IEvangelist requested review from Copilot and danegsta June 26, 2026 15:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the aspire doctor reference documentation to reflect the new “Operating system” environment check added in microsoft/aspire#18252, including updated table output and JSON schema details for tooling.

Changes:

  • Expand “Environment checks” description to include OS reporting details (type/version/distro info).
  • Update the sample table output to include the OS check and adjust the summary count accordingly.
  • Extend the JSON output example and documentation with the new operating-system check and its metadata fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- **SDK checks**: Verifies .NET SDK installation and version requirements
- **Container checks**: Validates container runtime (Docker and/or Podman) availability, running status, and version. Reports which runtime is active and why (explicit configuration, auto-detected default, or auto-detected only runtime running)
- **Environment checks**: Validates environment variables and other settings, including the JavaScript toolchain required by TypeScript AppHosts (npm, pnpm, Yarn, or Bun)
- **Environment checks**: Reports operating system information (type, version, and Linux distro details when available) and validates environment variables and other settings, including the JavaScript toolchain required by TypeScript AppHosts (npm, pnpm, Yarn, or Bun)
Comment on lines 102 to +106
Environment
✅ Operating system: macOS 15.5.0
✅ HTTPS development certificate is trusted

Summary: 5 passed, 0 warnings, 0 failed
Summary: 6 passed, 0 warnings, 0 failed
@IEvangelist

Copy link
Copy Markdown
Member

[docs-from-code-ci-note] CI has been retriggered multiple times and is still failing due to the current PR changes (not a transient runner issue). Please update the PR changes to fix the failing checks.

@IEvangelist

Copy link
Copy Markdown
Member

We've retriggered CI multiple times, and the current failures appear tied to changes in this PR rather than a transient pipeline issue. This likely needs a fix in the PR branch before CI will pass.

@IEvangelist

Copy link
Copy Markdown
Member

CI has been retriggered multiple times and is still failing for this PR (latest failures: 'CI' (attempt 8)). This likely needs changes in the PR itself rather than another rerun.

@IEvangelist

Copy link
Copy Markdown
Member

This PR has had CI retriggered multiple times and is still failing on PR-specific checks. It likely needs a change in this PR to pass.

@IEvangelist

Copy link
Copy Markdown
Member

[docs-from-code automation] repeated-rerun-note
CI has been retriggered multiple times and is still failing on this PR. This now looks likely to be caused by the PR changes rather than transient CI flakiness; it probably needs a content/code fix in this branch.

@IEvangelist

Copy link
Copy Markdown
Member

We've retriggered CI many times on this PR and it's still failing. At this point, the failure likely comes from changes in this PR rather than transient CI flakiness, so this probably needs a content/code fix in the PR itself.

@IEvangelist

Copy link
Copy Markdown
Member

CI has failed repeatedly on this docs-from-code PR after multiple reruns, and the failures appear to be related to the changes in this PR. Please review and adjust the PR content so the checks can pass.

@IEvangelist

Copy link
Copy Markdown
Member

CI has been retriggered multiple times on this PR and is still failing. The failures appear tied to the current PR changes rather than a transient runner issue, so this likely needs an update in the PR content before CI will pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-from-code Copilot initiated issue from dotnet/aspire repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants