Skip to content

[docs] Document icon fallback behavior for resource commands#1277

Open
aspire-repo-bot[bot] wants to merge 2 commits into
release/13.5from
docs/dashboard-command-icon-fallback-18389-157788be45f91569
Open

[docs] Document icon fallback behavior for resource commands#1277
aspire-repo-bot[bot] wants to merge 2 commits into
release/13.5from
docs/dashboard-command-icon-fallback-18389-157788be45f91569

Conversation

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Documents changes from microsoft/aspire#18389 (by @JamesNK).

Targeting release/13.5 based on the source PR milestone 13.5.

Why this PR is needed

PR microsoft/aspire#18389 fixed a dashboard overflow bug: when a resource command had IsHighlighted = true and specified an unrecognized iconName, the dashboard previously rendered the raw displayName text in the inline action button slot. A long display name could widen the resource row past the viewport, pushing the ... overflow menu off-screen.

The fix introduces two new fallback behaviors that users of the WithCommand / iconName API need to know about:

  • Unknown icon name — if iconName resolves to no known Fluent UI icon, the dashboard now renders a QuestionCircle (❓) icon instead of the display-name text.
  • No icon name on a highlighted command — if IsHighlighted = true and iconName is omitted, the dashboard renders a Flash (⚡) icon by default, keeping the button compact.

What was changed

Updated the iconName parameter description in src/frontend/src/content/docs/fundamentals/custom-resource-commands.mdx to document both fallback behaviors.

Files modified

  • src/frontend/src/content/docs/fundamentals/custom-resource-commands.mdx — updated existing page

Generated by PR Documentation Check for issue #18389 · 1.2K AIC · ⌖ 20.6 AIC · ⊞ 45.5K ·

When a resource command specifies an unrecognized iconName, the
dashboard now renders a QuestionCircle (question mark circle) icon
as a fallback instead of displaying the raw display-name text.
For highlighted commands (IsHighlighted = true) with no iconName,
the dashboard uses a Flash icon by default so the inline action
button stays compact and never overflows the resource row.

Documents changes from microsoft/aspire#18389.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@aspire-repo-bot aspire-repo-bot Bot added the docs-from-code Copilot initiated issue from dotnet/aspire repo label Jun 22, 2026
@aspire-repo-bot aspire-repo-bot Bot requested a review from davidfowl June 22, 2026 05:22
@aspire-repo-bot

Copy link
Copy Markdown
Contributor Author

Frontend HTML artifact ready

The latest frontend build uploaded the frontend-dist artifact for PR #1277. Use the VS Code button below to open this PR with GitHub Artifacts Explorer and browse the built HTML locally.

VS Code: Open PR #1277 artifacts

This comment updates automatically when a new frontend build artifact is uploaded.

@JamesNK JamesNK marked this pull request as ready for review June 22, 2026 22:58
@JamesNK JamesNK requested a review from IEvangelist as a code owner June 22, 2026 22:58
Copilot AI review requested due to automatic review settings June 22, 2026 22:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Aspire docs to describe the dashboard’s new icon fallback behavior for custom resource commands, so users understand what happens when iconName is missing or invalid (especially for highlighted commands that render as inline action buttons).

Changes:

  • Expanded the iconName parameter description to document:
    • fallback to a QuestionCircle icon when an unknown icon name is provided
    • default Flash icon when a highlighted command omits iconName

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/frontend/src/content/docs/fundamentals/custom-resource-commands.mdx Outdated
Comment thread src/frontend/src/content/docs/fundamentals/custom-resource-commands.mdx Outdated
Comment thread src/frontend/src/content/docs/fundamentals/custom-resource-commands.mdx Outdated
@IEvangelist IEvangelist requested a review from JamesNK June 27, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-from-code Copilot initiated issue from dotnet/aspire repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants