Skip to content

Add doc-pr-reviewer skill for single-PR docs accuracy review#1298

Open
IEvangelist wants to merge 5 commits into
mainfrom
ievangelist-dapine-pr-code-review-skill
Open

Add doc-pr-reviewer skill for single-PR docs accuracy review#1298
IEvangelist wants to merge 5 commits into
mainfrom
ievangelist-dapine-pr-code-review-skill

Conversation

@IEvangelist

Copy link
Copy Markdown
Member

Summary

Adds a new doc-pr-reviewer skill at .agents/skills/doc-pr-reviewer/SKILL.md, derived from the docs-accuracy reviewer workflow prompt but reworked to review a single pull request passed as a parameter rather than running on a schedule.

What it does

The skill verifies that every factual claim a documentation PR makes about Aspire matches the microsoft/aspire source code (Phase A), validates the docs as a new user via the doc-tester skill (Phase B), and posts a single merged review (Phase C).

Changes from the original reviewer prompt

  • # Input replaces # Selection — takes one PR (number or URL); no docs-from-code label filter, oldest-first sort, or skip-already-reviewed loop.
  • Removed # Rinse and repeat — no looping over multiple PRs.
  • Stripped skip preconditions — no draft / merge-conflict / "no matching branch → exit" gates. The no-matching-branch case now falls back to the closest branch and records which branch/SHA was used instead of bailing.
  • Kept Phase A/B/C discipline intact; corrected the doc-tester path to this repo's actual location (.agents/skills/doc-tester/SKILL.md).
  • Updated # Safety — removed the hourly-loop "next run continues" language; kept read-only rules and [partial] labeling.

Adds a new .agents/skills/doc-pr-reviewer skill derived from the docs-accuracy reviewer workflow prompt, reworked to review a single PR passed as a parameter (number or URL) instead of selecting PRs by the docs-from-code label. Removes the selection loop, the rinse-and-repeat loop, and the draft/conflict/branch-mismatch skip preconditions. Keeps the Phase A (claims verification against microsoft/aspire source), Phase B (doc-tester run), and Phase C (merged single review) discipline.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 25, 2026 18:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new agent skill (doc-pr-reviewer) intended to review a single aspire.dev documentation PR for factual accuracy against microsoft/aspire, then validate the docs experience via doc-tester, and finally post one merged review.

Changes:

  • Introduces .agents/skills/doc-pr-reviewer/SKILL.md defining a 3-phase single-PR docs accuracy workflow (claims verification, doc-tester run, merged review).
  • Documents branch/SHA “source of truth” selection for microsoft/aspire, including a fallback when no matching branch exists.
  • Defines a combined output format and review-verdict rules based on Phase A/Phase B results.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .agents/skills/doc-pr-reviewer/SKILL.md Outdated
Comment thread .agents/skills/doc-pr-reviewer/SKILL.md Outdated
Comment thread .agents/skills/doc-pr-reviewer/SKILL.md Outdated
IEvangelist and others added 4 commits June 25, 2026 13:50
…right-cli

Routes claims to CommunityToolkit/Aspire as the source of truth for Community Toolkit integration changes (CommunityToolkit.Aspire.* packages / integrations docs), while keeping microsoft/aspire for core Aspire. Clarifies that Phase A and Phase B are independent and may run in parallel for speed (Phase B's only input is the PR's changed files, not Phase A's catalog), and makes Phase B explicitly require the playwright-cli skill rather than Playwright directly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Removes manual mid-paragraph line breaks so paragraphs and list items are single lines, matching sibling skills (tooling soft-wraps the text). No content changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ost-review cleanup to doc-pr-reviewer

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…R review

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@IEvangelist IEvangelist enabled auto-merge (squash) June 25, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants