UX improvements - code block and file tree icons, instead of text and gray iconography#1304
Draft
IEvangelist wants to merge 7 commits into
Draft
UX improvements - code block and file tree icons, instead of text and gray iconography#1304IEvangelist wants to merge 7 commits into
IEvangelist wants to merge 7 commits into
Conversation
…yment documentation fix(docs): refine code block titles for clarity in Python and JavaScript sections style(css): enhance site styles with new file tree icon size and abbr cursor feat(docs): introduce Kubernetes clusters deployment guide with Helm integration feat(unocss): add UnoCSS configuration for Starlight icons support
… to './.aspire/modules/aspire.mjs'
IEvangelist
requested review from
JamesNK,
aaronpowell,
davidfowl,
eerhardt and
maddymontaquila
as code owners
Contributor
Frontend HTML artifact readyThe latest frontend build uploaded the This comment updates automatically when a new frontend build artifact is uploaded. |
… chunks resolve it ec.config.mjs loaded pluginIcon from starlight-plugin-icons using a URL resolved against import.meta.url. During the build's prerender phase Astro bundles this config into dist/.prerender/chunks/, which moves import.meta.url away from the project root, so the ./node_modules/...expressive-code.ts URL pointed at a non-existent path. The import threw and the <Code> component renderer silently fell back to a default Expressive Code config, producing a different asset hash than the markdown renderer. Pages then referenced EC stylesheet/script files that were never emitted (404s), which broke code-block styling/icons and caused header/cookie layout instability that timed out the Playwright UI-regression tests. Resolve the plugin source from process.cwd() (the project root) so the path stays valid in both the integration and bundled prerender contexts, keeping a single EC config and a single emitted asset bundle. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The 'homepage header actions stay reachable at zoomed and reflow widths' desktop test repeatedly navigates home -> install-cli -> home across narrow widths. Starlight's view transitions animate those navigations, and in headless Chromium a transition started on the second homepage visit can stall the compositor (requestAnimationFrame stops firing), freezing the whole page so every header action becomes unclickable and the click times out. Disable motion for the test so Starlight skips the view-transition animations, keeping the page interactive across the repeated navigations. This matches the existing reduced-motion pattern already used in integrations-gallery.spec.ts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
auto-merge was automatically disabled
June 27, 2026 14:39
Pull request was converted to draft
…ilds PR #1304 added starlight-plugin-icons but icons disappeared in two scenarios: 1. CI (missing icon CSS): uno.config.ts uses only presetStarlightIcons, whose CSS is driven entirely by .starlight-icons/safelist.json. That file was gitignored, so on a fresh CI clone UnoCSS read an empty safelist and emitted zero i-material-icon-theme:* rules - the injected icon spans rendered at 0x0 (invisible). Vendoring safelist.json guarantees UnoCSS generates the icon CSS on a fresh clone (verified: 70 entries -> 68 icon rules with SVG data-URIs; empty safelist -> 0 bytes). 2. Local/offline (no icon data): getMaterialIconsData() does an unconditional network fetch and returns undefined on failure, so resolveIcon injects no span at all. A pnpm patch makes it fall back to the vendored .starlight-icons cache (upstreamed as Rettend/starlight-plugin-icons#9), and the icon data is now committed so the fallback always has data. Changes: - Vendor src/frontend/.starlight-icons (icon data + safelist.json); un-ignore the dir in .gitignore. - Add pnpm patch patches/starlight-plugin-icons@1.1.6.patch and register it in pnpm-workspace.yaml / pnpm-lock.yaml (frozen-lockfile install verified). - Ignore Playwright blob-report/. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixed many legacy
apphost.tsoccurrences.Before
After