Revert commit SHA resolution to git merge-base#628
Merged
IEvangelist merged 2 commits intomainfrom Mar 30, 2026
Merged
Conversation
Closed
Agent-Logs-Url: https://github.com/microsoft/aspire.dev/sessions/337b5434-139d-42ba-b79d-a75e938f2f02 Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix broken commit link on deployment page
Revert commit SHA resolution to git merge-base
Mar 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the frontend footer’s commit SHA link by changing how the build determines the commit: instead of using CI-provided SHA values that may refer to synthetic merge commits, it resolves a commit that exists on the public main history via git merge-base.
Changes:
- Remove CI/env-based SHA resolution and compute the commit via
git merge-base .../main HEAD. - Add
upstream/mainas a fallback remote for fork workflows while keeping the.env.localwrite logic from #601.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
IEvangelist
approved these changes
Mar 27, 2026
eerhardt
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The footer's commit link was broken because PR #601 changed
getCommit()to useGITHUB_SHA/git rev-parse HEAD, both of which can produce synthetic merge commit SHAs that don't exist in the public repo history.Changes
src/frontend/scripts/write-git-env.mjs: RevertsgetCommit()togit merge-base origin/main HEADwithupstream/main HEADas a fork fallback — this always resolves to a real commit onmain.The non-breaking
.env.localfile I/O refactor from PR #601 is retained.⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.