Skip to content

docs: Fix Aspire.Hosting.Integration.Analyzers package reference in multi-language integration authoring guide#982

Merged
sebastienros merged 2 commits into
mainfrom
dapine/fix-analyzers-docs-reference
May 26, 2026
Merged

docs: Fix Aspire.Hosting.Integration.Analyzers package reference in multi-language integration authoring guide#982
sebastienros merged 2 commits into
mainfrom
dapine/fix-analyzers-docs-reference

Conversation

@IEvangelist

@IEvangelist IEvangelist commented May 15, 2026

Copy link
Copy Markdown
Member

Summary

The Multi-language integrations authoring guide currently tells readers to install a NuGet package that does not exist:

<PackageReference Include="Aspire.Hosting.Integration.Analyzers" Version="13.3.0">
    <PrivateAssets>all</PrivateAssets>
    <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>

The corresponding project in microsoft/aspire (Aspire.Hosting.Integration.Analyzers.csproj) sets <IsPackable>false</IsPackable> — the analyzer never ships as a standalone NuGet. Anyone following the guide hits NU1101.

How the analyzer actually ships

It is embedded inside the Aspire.Hosting NuGet package via the IncludeIntegrationAnalyzerInPackage target in Aspire.Hosting.csproj and activated by an MSBuild flag in buildTransitive/Aspire.Hosting.targets:

<PropertyGroup>
  <EnableAspireIntegrationAnalyzers Condition="''$(EnableAspireIntegrationAnalyzers)'' == ''''">false</EnableAspireIntegrationAnalyzers>
</PropertyGroup>

<ItemGroup Condition="''$(EnableAspireIntegrationAnalyzers)'' == ''true''">
  <Analyzer Include="$(_AspireIntegrationAnalyzerAssembly)" Condition="Exists(''$(_AspireIntegrationAnalyzerAssembly)'')" />
</ItemGroup>

So integration authors just opt in:

<PropertyGroup>
    <EnableAspireIntegrationAnalyzers>true</EnableAspireIntegrationAnalyzers>
</PropertyGroup>

Changes

  • Rename the ## Install the analyzer section to ## Enable the analyzer, explain that the analyzer ships inside Aspire.Hosting, and replace the bogus PackageReference snippet with the EnableAspireIntegrationAnalyzers opt-in.
  • Update the ## Analyzer diagnostics lede so it no longer names the non-existent package.

Fixes #981.

The "Install the analyzer" section in the multi-language integration
authoring guide instructed readers to add a PackageReference to
`Aspire.Hosting.Integration.Analyzers`. That package does not exist on
NuGet — the project in microsoft/aspire is `IsPackable=false`. The
analyzer DLL ships embedded inside the `Aspire.Hosting` package and is
activated via the `EnableAspireIntegrationAnalyzers` MSBuild property.

Update the section (and the diagnostics-table heading prose) to reflect
how the analyzer actually ships and how consumers enable it.

Fixes #981

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 15, 2026 15:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Multi-language integrations authoring guide to remove instructions that reference a non-existent Aspire.Hosting.Integration.Analyzers NuGet package, aligning the docs with how the analyzer actually ships (embedded in Aspire.Hosting) and is enabled via MSBuild.

Changes:

  • Renames “Install the analyzer” to “Enable the analyzer” and replaces the invalid PackageReference with the EnableAspireIntegrationAnalyzers opt-in property.
  • Updates the analyzer diagnostics section intro to describe opt-in behavior instead of referencing the non-existent package.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@sebastienros sebastienros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after preserving the legacy analyzer-section anchor.

@sebastienros sebastienros enabled auto-merge (squash) May 26, 2026 22:00
@sebastienros sebastienros merged commit b43ada5 into main May 26, 2026
9 checks passed
@sebastienros sebastienros deleted the dapine/fix-analyzers-docs-reference branch May 26, 2026 22:22
IEvangelist added a commit that referenced this pull request Jun 1, 2026
* docs: Fix Aspire.Hosting.Integration.Analyzers package reference in multi-language integration authoring guide (#982)

* docs: Fix Aspire.Hosting.Integration.Analyzers package reference

The "Install the analyzer" section in the multi-language integration
authoring guide instructed readers to add a PackageReference to
`Aspire.Hosting.Integration.Analyzers`. That package does not exist on
NuGet — the project in microsoft/aspire is `IsPackable=false`. The
analyzer DLL ships embedded inside the `Aspire.Hosting` package and is
activated via the `EnableAspireIntegrationAnalyzers` MSBuild property.

Update the section (and the diagnostics-table heading prose) to reflect
how the analyzer actually ships and how consumers enable it.

Fixes #981

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs: Preserve analyzer section anchor

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: David Pine <dapine@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Sebastien Ros <sebastienros@gmail.com>

* Block rendered twoslash failures (#1085)

Co-authored-by: David Pine <7679720+IEvangelist@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Hide most Asciinema embeds (#1086)

Remove the repeated Asciinema recordings from CLI command docs, the CLI overview, AI coding agent docs, and the install component while leaving a single reference landing-page showcase in place.

Co-authored-by: David Pine <7679720+IEvangelist@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Improve Mermaid loading styles (#1102)

* Improve Mermaid loading styles

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Refine Mermaid loading skeleton

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: David Pine <7679720+IEvangelist@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Move repository skills to .agents (#1093)

* Move repository skills to .agents

Consolidate repository-owned skill files under .agents/skills and update repo guidance references to the standard location.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Prefer playwright-cli in doc skills

Update doc-writer and doc-tester guidance to direct browser-based validation through playwright-cli instead of MCP-backed browser tooling.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Move twoslash validator skill to .agents

Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>

---------

Co-authored-by: David Pine <7679720+IEvangelist@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

---------

Co-authored-by: David Pine <dapine@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Sebastien Ros <sebastienros@gmail.com>
Co-authored-by: David Pine <7679720+IEvangelist@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-language integration authoring docs reference a non-existent Aspire.Hosting.Integration.Analyzers NuGet package

4 participants