Skip to content

Fix call stack exceeded frontend error by ensuring dialog close before nested dialog opens#14654

Merged
JamesNK merged 2 commits intomicrosoft:release/13.2from
adamint:release/13.2
Feb 24, 2026
Merged

Fix call stack exceeded frontend error by ensuring dialog close before nested dialog opens#14654
JamesNK merged 2 commits intomicrosoft:release/13.2from
adamint:release/13.2

Conversation

@adamint
Copy link
Copy Markdown
Member

@adamint adamint commented Feb 24, 2026

Description

Ensures dialog is closed before manage telemetry dialog opens.

Fixes #14407

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

adamint and others added 2 commits February 24, 2026 12:21
…ings dialog (microsoft#14407)

Close the Settings dialog before opening the ManageDataDialog to prevent
concurrent focus traps from causing a 'Maximum call stack size exceeded'
error in the browser's web-components.js.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@adamint adamint requested review from JamesNK and Copilot and removed request for Copilot February 24, 2026 17:39
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14654

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14654"

@adamint adamint changed the title Release/13.2 Fix call stack exceeded frontend error by ensuring dialog close before nested dialog opens Feb 24, 2026
@JamesNK JamesNK merged commit 89d4fc3 into microsoft:release/13.2 Feb 24, 2026
347 of 348 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 13.2 milestone Feb 24, 2026
Copilot AI pushed a commit that referenced this pull request Mar 10, 2026
…ings dialog (#14407) (#14654)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants