Add polyglot exports for ApplicationInsights#14751
Merged
davidfowl merged 1 commit intorelease/13.2from Feb 27, 2026
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14751Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14751" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Aspire Type System (ATS) exports for the Azure Application Insights integration so it’s callable from TypeScript AppHosts, and introduces a TypeScript ValidationAppHost to exercise the exported surface.
Changes:
- Added
[AspireExport]forAddAzureApplicationInsightsandWithLogAnalyticsWorkspace, and[AspireExportIgnore]for non-ATS-friendly overloads. - Added a new
playground/polyglot/TypeScript/.../ValidationAppHostfor Azure Application Insights. - Updated
.gitignoreTypeScript AppHost ignore rules (notably affecting.modules/).
Reviewed changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure.ApplicationInsights/AzureApplicationInsightsExtensions.cs | Exports/ignores specific overloads for ATS/polyglot compatibility. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/apphost.ts | Exercises the exported Application Insights + Log Analytics APIs from TypeScript. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/apphost.run.json | Adds a run profile for the validation apphost. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/.aspire/settings.json | Declares TypeScript AppHost settings + package references. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/package.json | Defines TS build/run dependencies for the validation apphost. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/package-lock.json | Locks npm dependencies for the validation apphost. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/tsconfig.json | TS compiler configuration for the validation apphost. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/.modules/transport.ts | Adds generated TS SDK transport/runtime module. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/.modules/base.ts | Adds generated TS SDK base types module. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/.modules/.codegen-hash | Adds generated codegen hash marker. |
| .gitignore | Adjusts ignore rules for TypeScript AppHost outputs. |
Files not reviewed (1)
- playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/.modules/transport.ts:4
- These
.modules/*files are code-generated SDK artifacts (the presence of.codegen-hashindicates this) and typically shouldn’t be committed as source. Committing generated modules makes PRs noisy and risks them getting out of sync with the current ATS capability surface; prefer generating them on first run (per polyglot-apphost spec) and keeping them ignored by git.
// transport.ts - ATS transport layer: RPC, Handle, errors, callbacks
import * as net from 'net';
import * as rpc from 'vscode-jsonrpc/node.js';
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22465468429 |
davidfowl
approved these changes
Feb 27, 2026
76 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #14069