Improve agent init skill install output#17519
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17519Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17519" |
IEvangelist
requested review from
JamesNK,
davidfowl and
mitchdenny
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves aspire agent init output by replacing repeated per-skill install messages with a compact summary of installed skills and locations, while preserving detailed failure output.
Changes:
- Collects successful skill install results and emits one summarized Robot message.
- Adds resource strings for the summary header, skills line, and locations line.
- Updates tests and localization resource artifacts for the new output shape.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Aspire.Cli/Commands/AgentInitCommand.cs |
Aggregates updated skill/location pairs and displays a single install summary. |
src/Aspire.Cli/Resources/AgentCommandStrings.resx |
Replaces the per-skill install string with summary-related resource strings. |
src/Aspire.Cli/Resources/AgentCommandStrings.Designer.cs |
Adds generated accessors for the new resource strings. |
src/Aspire.Cli/Resources/xlf/AgentCommandStrings.cs.xlf |
Updates Czech localization units for the new strings. |
src/Aspire.Cli/Resources/xlf/AgentCommandStrings.de.xlf |
Updates German localization units for the new strings. |
src/Aspire.Cli/Resources/xlf/AgentCommandStrings.es.xlf |
Updates Spanish localization units for the new strings. |
src/Aspire.Cli/Resources/xlf/AgentCommandStrings.fr.xlf |
Updates French localization units for the new strings. |
src/Aspire.Cli/Resources/xlf/AgentCommandStrings.it.xlf |
Updates Italian localization units for the new strings. |
src/Aspire.Cli/Resources/xlf/AgentCommandStrings.ja.xlf |
Updates Japanese localization units for the new strings. |
src/Aspire.Cli/Resources/xlf/AgentCommandStrings.ko.xlf |
Updates Korean localization units for the new strings. |
src/Aspire.Cli/Resources/xlf/AgentCommandStrings.pl.xlf |
Updates Polish localization units for the new strings. |
src/Aspire.Cli/Resources/xlf/AgentCommandStrings.pt-BR.xlf |
Updates Portuguese (Brazil) localization units for the new strings. |
src/Aspire.Cli/Resources/xlf/AgentCommandStrings.ru.xlf |
Updates Russian localization units for the new strings. |
src/Aspire.Cli/Resources/xlf/AgentCommandStrings.tr.xlf |
Updates Turkish localization units for the new strings. |
src/Aspire.Cli/Resources/xlf/AgentCommandStrings.zh-Hans.xlf |
Updates Simplified Chinese localization units for the new strings. |
src/Aspire.Cli/Resources/xlf/AgentCommandStrings.zh-Hant.xlf |
Updates Traditional Chinese localization units for the new strings. |
tests/Aspire.Cli.Tests/Commands/AgentInitCommandTests.cs |
Updates and adds tests for the summarized install output. |
Files not reviewed (1)
- src/Aspire.Cli/Resources/AgentCommandStrings.Designer.cs: Language not supported
Contributor
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
davidfowl
approved these changes
May 27, 2026
Contributor
|
❓ CLI E2E Tests unknown — 107 passed, 0 failed, 2 unknown (commit View all recordings
📹 Recordings uploaded automatically from CI run #26488452088 |
aspire-repo-bot Bot
added a commit
to microsoft/aspire.dev
that referenced
this pull request
May 27, 2026
Document the improved compact summary output introduced in microsoft/aspire#17519. The command now prints one consolidated message listing all installed skills and locations instead of a separate line per skill. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Pull request created: #1087
|
Contributor
|
📝 Documentation has been drafted in microsoft/aspire.dev#1087 targeting Updated Note This draft PR needs human review before merging. |
Member
Author
|
/backport to release/13.4 |
Contributor
|
Started backporting to |
Contributor
|
@IEvangelist an error occurred while backporting to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the
aspire agent initskill installation output so the useful data is easy to scan. The command now collects updated skill/location pairs and prints one compact summary instead of repeating one success line for every skill at every install target.Before:
After:
Detailed failure messages still include the exact skill path that failed, and no-op installs stay quiet except for the existing final success message.
User-facing usage
Running
aspire agent initwith selected skills now summarizes the result:Observed local output:
Validation:
dotnet build /t:UpdateXlf src\Aspire.Cli\Aspire.Cli.csprojdotnet test --project tests\Aspire.Cli.Tests\Aspire.Cli.Tests.csproj --no-launch-profile -- --filter-class "*.AgentInitCommandTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"dotnet run --project src\Aspire.Cli\Aspire.Cli.csproj -- agent init --workspace-root <temp-workspace> --skill-locations claudecode --skills aspire,aspireify,aspire-deploymentFollow-up validation after PR CI publishes an Aspire CLI artifact: download the artifact and run
aspire new aspire-ts-starter -n aspire-app -o aspire-app, answeryto AI setup, and select the defaults.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?