[release/13.4] Stabilizing builds in preparation for 13.4 release#17520
Merged
Conversation
Flip StabilizePackageVersion default to true in eng/Versions.props. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17520Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17520" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes package versioning on the release/13.4 branch by flipping the default StabilizePackageVersion MSBuild property to produce stable (non-prerelease) package versions by default for release builds.
Changes:
- Set
StabilizePackageVersiondefault totrueineng/Versions.propsto enable stable package version output on the release branch.
Show a summary per file
| File | Description |
|---|---|
| eng/Versions.props | Flips the default stabilization flag so versioning resolves to stable (release) by default on the branch. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
23
to
25
| <!-- Enable to remove prerelease label. --> | ||
| <StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">false</StabilizePackageVersion> | ||
| <StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">true</StabilizePackageVersion> | ||
| <DotNetFinalVersionKind Condition="'$(StabilizePackageVersion)' == 'true'">release</DotNetFinalVersionKind> |
Contributor
|
✅ No documentation update needed. docs_optional → No signals triggered. The single changed file is |
pull Bot
pushed a commit
to tooniez/aspire
that referenced
this pull request
Jun 2, 2026
Brings 43 release-branch commits forward onto main now that 13.4.0 has shipped. This PR replaces the original automated merge (microsoft#17804) which had to be closed so that conflict resolution and post-merge cleanups could be made on a non-protected branch. Conflict resolution summary (33 files): * Equivalent backports (took main's commit identity): ChannelUpdateWorkflowTests, LoggingHelpersTests, the four extension test files, AspireEditorCommandProvider, appHostDiscovery. * Release-only forwards (preserved): microsoft#17732 / microsoft#17756 Foundry hosted-agent protocol selection and cross-compute-environment endpoint references, microsoft#17573 stabilize PrebuiltAppHostServer staging globalPackagesFolder path, microsoft#17743 staging-identity CLI darc feed routing. * Main-only forwards (preserved): microsoft#17506 Show discovered AppHosts in Aspire pane, microsoft#17547 Localize Aspire skills metadata errors, microsoft#17801 VS Code v1.12.0, microsoft#17297 Aspire CLI npm package release integration, microsoft#17576 TerminalRun IAsyncDisposable, microsoft#17721 / microsoft#17723 VS Code telemetry, microsoft#17671 ATS baseline fix (re-applied manually on top of Foundry source taken from release). * Hybrid (manually spliced): docs/contributing.md - kept main's restructured layout and inserted release's staging-validation paragraph; HostedAgentBuilder- Extension - took release base then re-applied microsoft#17671 asHostedAgent rename; UpdateCommandTests - took main and injected microsoft#17743's OverrideCliInformationalVersionConfigKey block. Post-merge cleanups included in this PR: * eng/Versions.props: revert StabilizePackageVersion to false (was flipped to true on release/13.4 by microsoft#17520 for shipping 13.4.0; main must stay in preview mode). * .github/workflows/generate-api-diffs.yml: retarget back to main (was pointed at release/13.4 by microsoft#17696 release prep). * .github/workflows/backmerge-release.yml: update from release/13.3 to release/13.4 (was stale - missed the 13.4 release-time bump). * .github/workflows/milestone-assignment.yml: audited - already correct (main -> 13.5, release/13.4 -> 13.4.x); no change. This merge commit must be preserved - do not squash on merge. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flip
StabilizePackageVersiondefault totrueineng/Versions.propsso the release/13.4 branch produces stable package versions.Background
Previously (see #16566 for release/13.3) stabilization required a sweep of changes: flipping the property, removing the PR-build version-suffix step, pinning the AppHost SDK in
RepoTesting.targets, pinning every stabilizable Aspire package inDirectory.Packages.Helix.props, and tweaking polyglot validation scripts to skip preview-only AppHosts.PR #15681 (
Automate version stabilization: dynamically compute package versions for Helix testing) collapses all of that into a single knob ΓÇö this PR is just that one-line flip.Validation
Built locally with the official-build configuration and stabilization on:
Result:
Build succeeded.ΓÇö 0 warnings, 0 errors. 119.nupkgfiles produced; stabilizable packages ship as13.4.0(e.g.Aspire.Hosting.13.4.0.nupkg,Aspire.AppHost.Sdk.13.4.0.nupkg), while packages that explicitly opt out viaSuppressFinalPackageVersion=true(the preview hosting integrations) correctly remain at13.4.0-preview.1.26051.99.