Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tests/Aspire.Hosting.Tests/Dcp/TestKubernetesService.cs:177
- Consider safely casting patch.Content (using a safe cast or adding a null-check) to avoid potential runtime exceptions if the content is not of type Json.Patch.JsonPatch.
Json.Patch.JsonPatch jsonPatch = (Json.Patch.JsonPatch)patch.Content;
JamesNK
approved these changes
Apr 4, 2025
mitchdenny
approved these changes
Apr 4, 2025
Member
|
Backport too please! |
Contributor
|
/backport to release/9.2 |
Contributor
|
Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14258144458 |
Contributor
|
@davidfowl backporting to "release/9.2" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Contributor
|
@karolz-ms all yours 😄 |
Contributor
Author
|
Honestly IMO this is not super critical to be backported to 9.2 but I will try |
Contributor
|
Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14269439222 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Applies retry logic to resource stopping operation
Fixes # (issue)
Fixes #8481
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):I ran all
Aspire.HostingandAspire.Hosting.Testingtests locally and only 2 quarantined tests failed (one passed on re-run). The changes toTestKubernetesServiceare required to make tests pass.