Skip to content

Removing node-sass and request package and adding sass instead - #142

Merged
David Paquette (dpaquette) merged 2 commits into
masterfrom
resolve-node-sass
May 12, 2023
Merged

Removing node-sass and request package and adding sass instead#142
David Paquette (dpaquette) merged 2 commits into
masterfrom
resolve-node-sass

Conversation

@lohitakshgupta

@lohitakshgupta Lohitaksh Gupta (lohitakshgupta) commented May 11, 2023

Copy link
Copy Markdown
Contributor

Removing node-sass and request and adding sass package instead to resolve alert: https://github.com/microsoft/azure-devops-extension-sample/security/dependabot/38

Ran the following commands:
npm uninstall node-sass
npm install sass
npm audit fix (which removed request package from package-lock.json)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to review this more closely. I will do that first thing tomorrow morning. I'm not sure why node-sass is still in the package-lock.json

Comment thread package-lock.json Outdated
@dpaquette
David Paquette (dpaquette) merged commit 6de8a97 into master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants