Fix update dialog pops several times when click ok/cancel button issue#2013
Merged
Conversation
t-rufang
force-pushed
the
issue_hotfix
branch
2 times, most recently
from
366b6f7 to
d1c5d9e
Compare
wezhang
reviewed
Sep 17, 2018
| try { | ||
| cluster.get().toBlocking().singleOrDefault(cluster); | ||
| if (Optional.ofNullable(cluster.getMasterState()).orElse("") | ||
| if (getNodeActionByName("Update") == null && Optional.ofNullable(cluster.getMasterState()).orElse("") |
Member
There was a problem hiding this comment.
I suppose you may need to remove all actions before adding one. The method name is refreshItems #Resolved
| if (Optional.ofNullable(cluster.getMasterState()).orElse("") | ||
| if (getNodeActionByName("Update") == null && Optional.ofNullable(cluster.getMasterState()).orElse("") | ||
| .equals(SparkItemGroupState.STABLE.toString())) { | ||
| addAction("Update", new SparkServerlessUpdateAction( |
Member
There was a problem hiding this comment.
why the action needs to be added twice? #Resolved
Contributor
Author
There was a problem hiding this comment.
After user provision a new cluster, the cluster state is not STABLE. So the actions for this new provisioned cluster node don't contain Update. Update action will be enabled when cluster is in STABLE state and user refreshes the node.
In reply to: 217964570 [](ancestors = 217964570)
t-rufang
force-pushed
the
issue_hotfix
branch
from
d1c5d9e to
6006747
Compare
wezhang
reviewed
Sep 17, 2018
| this, cluster, SparkServerlessClusterOps.getInstance().getUpdateAction())); | ||
| } | ||
| Boolean isClusterStabled = Optional.ofNullable(cluster.getMasterState()).orElse("") | ||
| .equals(SparkItemGroupState.STABLE.toString()); |
| addAction("Update", new SparkServerlessUpdateAction( | ||
| this, cluster, SparkServerlessClusterOps.getInstance().getUpdateAction())); | ||
| } | ||
| Boolean isClusterStabled = Optional.ofNullable(cluster.getMasterState()).orElse("") |
Member
There was a problem hiding this comment.
This val can be private function #Resolved
| this, cluster, SparkServerlessClusterOps.getInstance().getUpdateAction())); | ||
| } | ||
|
|
||
| NodeAction updateAction = addAction("Update", new SparkServerlessUpdateAction( |
Member
There was a problem hiding this comment.
Can we assign Update to a const String value? #Resolved
t-rufang
force-pushed
the
issue_hotfix
branch
2 times, most recently
from
6dc243b to
7af7782
Compare
wezhang
reviewed
Sep 18, 2018
| }); | ||
| } | ||
|
|
||
| private Boolean isClusterStable() { |
Member
There was a problem hiding this comment.
no boxing, boolean is enough #Resolved
t-rufang
force-pushed
the
issue_hotfix
branch
from
3c57c13 to
aa2a92d
Compare
wezhang
approved these changes
Sep 18, 2018
Member
wezhang
left a comment
wezhang
left a comment
There was a problem hiding this comment.
Thanks Rui! You can find the Squash operation.
andxu
pushed a commit
to andxu/azure-tools-for-java
that referenced
this pull request
Mar 24, 2020
microsoft#2013) * Fix update dialog pops several times when click ok/cancel button issue * Update based on review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #1920