Skip to content

Fix AuthException when account contains no subscription#4458

Merged
Flanker32 merged 17 commits into
microsoft:developfrom
Flanker32:hanxiao/0subs
Jun 22, 2020
Merged

Fix AuthException when account contains no subscription#4458
Flanker32 merged 17 commits into
microsoft:developfrom
Flanker32:hanxiao/0subs

Conversation

@Flanker32
Copy link
Copy Markdown
Member

@Flanker32 Flanker32 commented Jun 17, 2020 •
edited
Loading

  • Remove AuthExceptionand handle related exception when there is no subscriptions in user account
    • Now when users auth with an empty account, we will keep silent on auth and refresh, but show error prompt for action which need azure subscription
  • Pop up info dialog when find no subscriptions after sign-in/select subscriptopm
  • Fix Spring Cloud deployment panel refresh behavior

image

image

image

fixes #2226

@Flanker32 Flanker32 requested review from andxu and yucwan June 17, 2020 08:57
yucwan
yucwan previously approved these changes Jun 17, 2020
View reviewed changes
@yucwan yucwan dismissed their stale review June 17, 2020 09:11

cancel

@Flanker32 Flanker32 requested a review from yucwan June 17, 2020 09:11
andxu
andxu reviewed Jun 18, 2020
View reviewed changes
Comment thread Utils/azuretools-core/src/com/microsoft/azuretools/core/mvp/model/AzureMvpModel.java Outdated
@Flanker32 Flanker32 merged commit a269209 into microsoft:develop Jun 22, 2020
@Flanker32 Flanker32 deleted the hanxiao/0subs branch June 22, 2020 01:50
@andxu andxu mentioned this pull request Jul 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yucwan yucwan Awaiting requested review from yucwan

1 more reviewer

@andxu andxu andxu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[IntelliJ][ReportedByUser] MS Services - Error Getting Subscriptions

3 participants

@Flanker32 @andxu @yucwan