Enhance MySQL firewall public IP for local PC#5163
Conversation
| @@ -213,8 +213,8 @@ public static boolean isAllowAccessFromLocalMachine(final String subscriptionId, | |||
| } | |||
|
|
|||
| public static boolean isAllowAccessFromLocalMachine(final List<FirewallRuleInner> firewallRules) { | |||
There was a problem hiding this comment.
it's weird that we have to pass firewallRules as the parameter. I naturally think we should pass server as the parameter.
e.g. isLocalMachineAllowedAccess(server)
There was a problem hiding this comment.
isLocalMachineAllowedAccess(server) existed as well. it is a polymorphic one. in order to void to list firewall rules twice when when need to calculate access to local PC and other azure services.
There was a problem hiding this comment.
then this method may be renamed to something like isLocalMachineIncluded(rules)
|
it's basically OK for me about the logic part. and you may simplify the code by only providing these meta methods for firewall rules: so that, e.g. |
The base branch was changed.
No description provided.