refactor: make Common implementation details internal#1695
Merged
JamieMagee merged 1 commit intomainfrom Mar 6, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1695 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JamieMagee
force-pushed
the
jamiemagee/access-modifiers-detectors
branch
from
7913f32 to
c0bd795
Compare
Make ~50 classes internal in the Common project: - Telemetry records (~34 concrete classes): NuGetProjectAssetsTelemetryRecord, PyPiCacheTelemetryRecord, LinuxScannerTelemetryRecord, etc. Kept BaseDetectionTelemetryRecord public for external subclassing. - Utility classes: Column, TabularStringFormat, ComponentComparer, DependencyScopeComparer, DirectoryItemFacade(Optimized) - Docker reference exceptions (11 classes) - Concrete service implementations: CommandLineInvocationService, EnvironmentVariableService, PathUtilityService, FileUtilityService, DirectoryUtilityService, DockerService, ConsoleWritingService, SafeFileEnumerableFactory, ComponentStreamEnumerableFactory, FastDirectoryWalkerFactory Kept public: FileWritingService, ComponentStream, LazyComponentStream, ComponentRecorder, CommandLineInvocationResult, CommandLineTelemetryService, BaseDetectionTelemetryRecord, and all interfaces. Part of #455
JamieMagee
force-pushed
the
jamiemagee/access-modifiers-common
branch
from
0bb1f7f to
545a7a2
Compare
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
jasonpaulos
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make ~50 classes
internalin the Common project. These are implementation details not intended to be part of the public API surface.Categories of changes
Telemetry records (~34 classes):
BaseDetectionTelemetryRecordpublic — subclassed by component-detection-internalUtility classes:
Docker reference exceptions (11 classes)
Concrete service implementations (all registered via DI as interfaces):
Kept public
FileWritingService/IFileWritingService— used by sbom-toolComponentStream,LazyComponentStream— used in detector base class signaturesComponentRecorder— used in Orchestrator public APICommandLineInvocationResult— returned by public interfaceBaseDetectionTelemetryRecord— subclassed externallyStacked on #1694
Part of #455