Skip to content

Bump mvn cli detector timeout to 9 min#1771

Merged
grvillic merged 2 commits intomainfrom
users/zhentan/bump-mvncli-timeout
Apr 8, 2026
Merged

Bump mvn cli detector timeout to 9 min#1771
grvillic merged 2 commits intomainfrom
users/zhentan/bump-mvncli-timeout

Conversation

@zhenghao104
Copy link
Copy Markdown
Contributor

@zhenghao104 zhenghao104 commented Apr 8, 2026

Make mvn cli detector respect cancellation token

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Maven CLI detector’s internal safety timeout for OnPrepareDetectionAsync to better bound potential hangs while still staying under the overall detection process timeout configured via the CLI.

Changes:

  • Increase PrepareDetectionTimeout from 5 minutes to 9 minutes.
  • Update the timeout’s XML documentation to explain the rationale.

@zhenghao104 zhenghao104 force-pushed the users/zhentan/bump-mvncli-timeout branch from 4b26796 to e07521f Compare April 8, 2026 04:11
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@zhenghao104 zhenghao104 enabled auto-merge (squash) April 8, 2026 04:16
@grvillic grvillic disabled auto-merge April 8, 2026 15:37
@grvillic grvillic merged commit c3ef82c into main Apr 8, 2026
24 checks passed
@grvillic grvillic deleted the users/zhentan/bump-mvncli-timeout branch April 8, 2026 15:43
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.0%. Comparing base (f40d70c) to head (35b7f9d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #1771   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants