fix - nested scrolling and full-row table selection for auto-approve preferences#256
Open
xinyi-gong wants to merge 2 commits into
Open
fix - nested scrolling and full-row table selection for auto-approve preferences#256xinyi-gong wants to merge 2 commits into
xinyi-gong wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the Auto-Approve preferences UI by making nested viewers scroll naturally inside a parent preference scroller, and by ensuring the “last” table column expands to fill remaining width (matching the existing Custom Instructions table behavior).
Changes:
- Added a shared SWT utility to forward vertical mouse-wheel events to a parent
ScrolledCompositewhen the nested viewer is at its scroll boundary. - Enabled vertical scrolling on the auto-approve Table/Tree viewers and applied the wheel-forwarding behavior.
- Updated the auto-approve tables to resize the last column to fill remaining width on control resize.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/utils/SwtUtils.java | Adds a helper to forward mouse-wheel scrolling from nested scrollables to a parent scroller at boundaries. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/TerminalAutoApproveSection.java | Enables V_SCROLL, forwards wheel at boundaries, and makes the status column fill remaining table width. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/McpAutoApproveSection.java | Enables V_SCROLL on the tree and forwards wheel at boundaries for better nested scrolling behavior. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/FileOperationAutoApproveSection.java | Enables V_SCROLL, forwards wheel at boundaries, and makes the status column fill remaining table width. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary