Skip to content

Fix Windows desktop OS build version reporting#1441

Open
bmehta001 wants to merge 1 commit into
microsoft:mainfrom
bmehta001:bhamehta/fix-windows-os-version
Open

Fix Windows desktop OS build version reporting#1441
bmehta001 wants to merge 1 commit into
microsoft:mainfrom
bmehta001:bhamehta/fix-windows-os-version

Conversation

@bmehta001
Copy link
Copy Markdown
Contributor

@bmehta001 bmehta001 commented May 18, 2026

Summary

  • Stop using stale BuildLabEx to populate Windows desktop OS full version.
  • Use servicing-aware CurrentBuildNumber/CurrentBuild plus UBR, falling back to RtlGetVersion() build when registry build values are unavailable.
  • Add a Windows PAL unit test for the formatted OS full version with and without UBR.

Fixes #1407

Validation

  • MSBuild.exe Solutions\MSTelemetrySDK.sln /target:Tests\UnitTests /p:BuildProjectReferences=true /p:Configuration=Release /p:Platform=x64 /p:PlatformToolset=v145 /verbosity:minimal
  • UnitTests.exe --gtest_filter=PalTests.* --gtest_color=no
  • UnitTests.exe --gtest_color=no (461 tests passed)

@bmehta001
Fix Windows OS build version reporting
5e7bf17 
Use servicing-aware registry values so desktop telemetry reports the current Windows build instead of stale BuildLabEx data after OS updates.

Files changed:

- lib/pal/desktop/WindowsDesktopSystemInformationImpl.cpp

- tests/unittests/PalTests.cpp

Fixes microsoft#1407

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bmehta001 bmehta001 requested a review from a team as a code owner May 18, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Windows] 1DS reports OS version of the base OS at RTM and does not reflect any servicing updates

1 participant

@bmehta001