Fix #357, #1001 - #1004
Merged
Merged
Conversation
…InterpretedByShell" Fix microsoft#357: "argsExpansion" does not do what it says in VSCode Treat non-array "args" in debug config as a request to prevent shell argument escaping and allow shell expansion. Remove "argsExpansion".
Pavel Minaev (int19h)
requested a review
from Karthik Nadig (karthiknadig)
as a code owner
August 4, 2022 00:31
Contributor
Author
|
Karthik Nadig (@karthiknadig) I have manually tested this on the most recent VSCode insiders. The only change on vscode-python side is to update the JSON schema to allow "args" to be single string rather than an array. It would be nice if there's also a way to specify that this isn't supported for "internalConsole", but if not, no big deal - the error message should be clear enough if somebody tries that. |
Member
|
/cc Paula (@paulacamargo25) Can you make the change that Pavel recommended here? |
|
Kudos, SonarCloud Quality Gate passed! |
Paula (paulacamargo25)
added a commit
to microsoft/vscode-python
that referenced
this pull request
Aug 31, 2022
Related to microsoft/debugpy#1004.
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1001: Enable controlling shell expansion via "argsCanBeInterpretedByShell"
Fix #357: "argsExpansion" does not do what it says in VSCode
Treat non-array "args" in debug config as a request to prevent shell argument escaping and allow shell expansion.
Remove "argsExpansion".