This repository was archived by the owner on Jun 11, 2026. It is now read-only.
Make semantics of Vocabulary.update more precise.#42
Closed
mallamanis wants to merge 1 commit into
Closed
Conversation
* This breaks backwards compatibility by renaming the argument `max_size` to `max_num_elements_to_add`. * Remove the assertion that didn't make sense (the size of the Vocabulary should be able to change).
mmjb
reviewed
Jan 27, 2020
| setuptools.setup( | ||
| name='dpu_utils', | ||
| version='0.2.7', | ||
| version='0.2.8', |
Contributor
There was a problem hiding this comment.
I kind of feel API-breaking changes should generate a major version bump; we haven't been very consistent about this anyway, but maybe it's time to be?
Contributor
Author
There was a problem hiding this comment.
You mean go to version 1.0, right? If so, it might be worth thinking if there are any other breaking API changes that we need to make here..
mmjb
approved these changes
Jan 27, 2020
Contributor
|
Yeah, that was my thought. Maybe it's time for 1.0 and breaking all kinds
of things :-)
We should discuss this offline, or maybe just create a 1.0 branch and keep
adding breaking changes to it for a while?
…On Mon, 27 Jan 2020, 20:26 Miltos, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In python/setup.py
<#42 (comment)>:
> @@ -5,7 +5,7 @@
setuptools.setup(
name='dpu_utils',
- version='0.2.7',
+ version='0.2.8',
You mean go to version 1.0, right? If so, it might be worth thinking if
there are any other breaking API changes that we need to make here..
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#42?email_source=notifications&email_token=ABKT62COC6BQIJSCF4WPQ3LQ74YLZA5CNFSM4KMAKVJKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCTGAOGI#discussion_r371435218>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKT62D624CIYHY5TN56MSLQ74YLZANCNFSM4KMAKVJA>
.
|
Contributor
Author
|
Closing this, towards a |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max_sizetomax_num_elements_to_add.