Skip to content

Fix typo in PurgeInstanceAsync #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidmrdavid merged 3 commits into from
Mar 26, 2024
Merged

Fix typo in PurgeInstanceAsync #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
082d5bb
fix typo in PurgeInstanceAsync
shivamkm07 Feb 13, 2024
5871749
Updates for release 1.2.1
shivamkm07 Feb 13, 2024
fe0263d
Merge branch 'main' into fix-purge
davidmrdavid Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

# v1.2.1

- Fix typo in `PurgeInstanceAsync` in `DurableTaskClient` (https://github.com/microsoft/durabletask-dotnet/pull/264)
- Fix `TaskFailureDetails.IsCausedBy` to support custom exceptions and 3rd party exceptions ([#273](https://github.com/microsoft/durabletask-dotnet/pull/273))
- Microsoft.Azure.DurableTask.Core dependency increased to `2.16.2`

Expand Down
2 changes: 1 addition & 1 deletion src/Client/Core/DurableTaskClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ public abstract Task ResumeInstanceAsync(
public abstract AsyncPageable<OrchestrationMetadata> GetAllInstancesAsync(OrchestrationQuery? filter = null);

/// <inheritdoc cref="PurgeInstanceAsync(string, PurgeInstanceOptions, CancellationToken)"/>
public virtual Task<PurgeResult> PurgeInstancesAsync(string instanceId, CancellationToken cancellation)
public virtual Task<PurgeResult> PurgeInstanceAsync(string instanceId, CancellationToken cancellation)
Comment thread
cgillum marked this conversation as resolved.
=> this.PurgeInstanceAsync(instanceId, null, cancellation);

/// <summary>
Expand Down
1 change: 1 addition & 0 deletions src/Client/Core/RELEASENOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix typo in `PurgeInstanceAsync` in `DurableTaskClient` (https://github.com/microsoft/durabletask-dotnet/pull/264)