refactor(test-harness): remove parseDefaultValue and CEM-related logic from SSR renderer#7532
Merged
radium-v merged 2 commits intoMay 22, 2026
Merged
Conversation
4c69360 to
6343cc4
Compare
janechu
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Remove the
parseDefaultValuefunction and all Custom Elements Manifest (CEM) loading logic from the SSR renderer in@microsoft/fast-test-harness. This code was a workaround to populate default component state from CEM metadata during SSR test rendering, but it is no longer needed. State is now supplied directly through the test fixtures.This is a refactor that reduces complexity and removes an implicit dependency on
custom-elements.jsonfiles at render time.📑 Test Plan
All existing tests pass. The
parseDefaultValuetest suite was removed along with the function itself. Remaining SSR renderer tests (renderTemplate,buildEntryHtml,buildState,createSSRRenderer) are unaffected.✅ Checklist
General
$ npm run change