-
Notifications
You must be signed in to change notification settings - Fork 475
[Chore] Publish symbols from CI builds to internal symbol server #4910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # Stage shipping binaries for symbol upload. Place this immediately after | ||
| # the Build step, BEFORE any task that runs `dotnet test` with a different | ||
| # /p:DebugType. The test step passes /p:DebugType=Full as a global MSBuild | ||
| # property, which propagates through P2P refs and rebuilds Core with a | ||
| # different MVID; if we staged after the test step, the binaries we upload | ||
| # would not match the binaries inside the shipping nupkg. | ||
| # | ||
| # The .pdb pattern is included for pipelines that build with | ||
| # /p:DebugType=portable (standalone PDBs). For pipelines using the csproj | ||
| # default of <DebugType>embedded</DebugType>, the PDB rides inside the DLL | ||
| # and the .pdb pattern matches nothing β harmless. We deliberately stay on | ||
| # SymWeb only (see publish-symbols-upload.yml's SubmitToInternet:false), | ||
| # so embedded-in-DLL is fine here. | ||
| parameters: | ||
| - name: condition | ||
| type: string | ||
|
|
||
| steps: | ||
| - task: CopyFiles@2 | ||
| displayName: 'Collect shipping binaries for symbol upload' | ||
| condition: ${{ parameters.condition }} | ||
| inputs: | ||
| SourceFolder: '$(Build.SourcesDirectory)' | ||
| Contents: | | ||
| src/**/bin/Release/**/Microsoft.FluentUI.*.dll | ||
| src/**/bin/Release/**/Microsoft.FluentUI.*.pdb | ||
| !src/Templates/** | ||
|
tlmii marked this conversation as resolved.
|
||
| TargetFolder: '$(Build.ArtifactStagingDirectory)/Symbols' | ||
| CleanTargetFolder: true | ||
| flattenFolders: false | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Upload the staged DLL (+ PDB, if standalone) pairs to the internal | ||
| # symbol server. SubmitToInternet:false keeps these out of the public | ||
| # symbol server (MSDL); the task will print a warning about that override | ||
| # which is intentional and safe to ignore. The counterpart to this template | ||
| # is publish-symbols-stage.yml, which must run earlier in the same job. | ||
| parameters: | ||
| - name: condition | ||
| type: string | ||
|
tlmii marked this conversation as resolved.
|
||
|
|
||
| steps: | ||
| - task: MicroBuildArchiveSymbols@6 | ||
| displayName: 'Archive symbols to internal symbol server' | ||
| condition: ${{ parameters.condition }} | ||
| inputs: | ||
| azureSubscription: 'VSEng-SymbolsUpload' | ||
| SymbolsFeatureName: 'FluentUIBlazor' | ||
| SymbolsProject: 'DDE' | ||
| SymbolsAgentPath: '$(Build.ArtifactStagingDirectory)/Symbols' | ||
| # FluentUI is a public Blazor library; we publish to SymWeb for | ||
| # internal debugging but intentionally skip MSDL because we do not | ||
| # currently publish symbols there for our packages. The task warns | ||
| # when SubmitToInternet is overridden β SuppressSymwebOnlyWarning | ||
| # acknowledges the override is deliberate. | ||
| SubmitToInternet: false | ||
| SuppressSymwebOnlyWarning: true | ||
| env: | ||
| SYSTEM_ACCESSTOKEN: $(System.AccessToken) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.