[DataGrid] Fix issue #5026 (from Aspire) - #5028
Merged
Merged
Conversation
vnbaaij
commented
Jul 20, 2026
vnbaaij
commented
Collaborator
- Extend a11y support for typical example by supplying HeaderTooltip values
- Add HeaerTooltip, aria-haspopup="menu and title to button in column header
- Return null for aria-sort if not sorted
- Set menu aria-expanded in script so it can cleanly be set when dismissed by overlay click
…valies - Add HeaerTooltip, aria-haspopup="menu and title to button in column header - Return null for aria-sort if not sorted - Set menu aria-expanded in script so it can cleanly be set when dismissed by overlay click
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses DataGrid accessibility behavior (issue #5026) by improving header/menu ARIA semantics and updating the “Typical” demo to provide more descriptive header tooltip text. It also adjusts the FluentMenu JS initialization to keep aria-expanded in sync when the menu is dismissed indirectly.
Changes:
- Set/maintain
aria-expandedon the menu anchor element from JS during FluentMenu initialization. - Change DataGrid header
aria-sortto be omitted (null) when a column is not sorted. - Update DataGrid column header button attributes (menu semantics) and extend the demo to supply
HeaderTooltipvalues.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Core/Components/Menu/FluentMenu.razor.js | Sets aria-expanded on the anchor during initialization. |
| src/Core/Components/DataGrid/FluentDataGrid.razor.cs | Changes aria-sort output to null when not sorted. |
| src/Core/Components/DataGrid/Columns/ColumnBase.razor | Adjusts header button ARIA/menu attributes and tooltip/title behavior. |
| examples/Demo/Shared/Pages/DataGrid/Examples/DataGridTypical.razor | Adds HeaderTooltip strings to the typical DataGrid example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61.3%
|
dvoituron
approved these changes
Jul 20, 2026
dvoituron
approved these changes
Jul 21, 2026
This was referenced Jul 30, 2026
Open
This was referenced Aug 3, 2026
Open
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.