chore: enable no-export-all on index files#1551
Merged
Merged
Conversation
Some bundlers, such as esbuild, are not able to tree-shake nested `export *` statements. Fixed them using the `no-export-all` ESLint rule.
Saadnajmi
approved these changes
Mar 30, 2022
rurikoaraki
reviewed
Mar 30, 2022
Collaborator
|
Out of curiosity, some index files are skipped, is that because they're not top-level files? |
Member
Author
This is the rule I added: It should only catch the |
rurikoaraki
approved these changes
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some bundlers, such as esbuild, are not able to tree-shake nested
export *statements. Fixed them using theno-export-allESLint rule.Platforms Impacted
Description of changes
Some bundlers, such as esbuild, are not able to tree-shake nested
export *statements.The Fluent team has also recently turned this on: microsoft/fluentui#22073
Fixed using the
no-export-allESLint rule.Verification
Functionally, nothing has changed.