Skip to content

Use FRNFontMetrics module in Text #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amgleitman merged 43 commits into from
Nov 28, 2022
Merged

Use FRNFontMetrics module in Text #2269

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
b7dd30e
Add FRNFontMetrics module
Oct 24, 2022
0e07035
Remove debugging `console.log` statements
Oct 24, 2022
f1aa83c
Use a hook to access font metrics
Nov 2, 2022
52b4fcf
Merge branch 'main' into furn-font-metrics
Nov 2, 2022
708530a
Add NativeFontMetrics package
Nov 2, 2022
cbcff5a
Remove unneeded API
Nov 3, 2022
f57023d
Fix spacing
Nov 3, 2022
98d8e12
Change files
Nov 3, 2022
96e09be
Add @types/use-subscription dependency
Nov 3, 2022
4b9eabc
Update yarn.lock
Nov 3, 2022
37191a3
Add use-subscription as a dependency
Nov 3, 2022
4743422
Update yarn.lock again
Nov 3, 2022
f6f5b17
NativeFontMetrics.tsx -> NativeFontMetrics.ts
Nov 3, 2022
245fd82
Make NativeFontMetrics iOS only, part 1
Nov 3, 2022
a4f879f
Stub out NativeFontMetrics for non-iOS platforms
Nov 3, 2022
2a25072
Keep use-subscription version consistent with react-native and react-…
Nov 3, 2022
0c97508
Remove core-android capability
Nov 4, 2022
ef44158
id -> UIFontTextStyle
Nov 4, 2022
c4c6015
Merge branch 'furn-font-metrics-package' into furn-font-metrics
Nov 4, 2022
2a9b966
Merge branch 'main' into furn-font-metrics
Nov 8, 2022
1e5c687
Delete old changefile
Nov 8, 2022
caa7688
Regenerate lockfiles
Nov 8, 2022
0b4f3df
Delete duplicate NativeFontMetrics.tsx file
Nov 8, 2022
2567141
Change files
Nov 8, 2022
7ac2160
allScaleFactors -> currentScaleFactors
Nov 11, 2022
c855df3
Use pure events to update font metrics
Nov 11, 2022
cf11e47
Update package.nuspec
Nov 11, 2022
bc4cb87
Merge branch 'main' into furn-font-metrics
Nov 11, 2022
a84bceb
Use pure JS hook to make V2 Texts rerender
Nov 16, 2022
b4cfea8
Merge branch 'main' into furn-font-metrics
Nov 17, 2022
205976b
Change files
Nov 17, 2022
ee4eedf
Update snapshot
Nov 17, 2022
4b88f71
Remove unneeded dependency
Nov 17, 2022
14dc48b
Move fontMetrics to iOS specific file
Nov 18, 2022
f4f7b91
Better isolation of iOS-specific code
Nov 18, 2022
b075082
Add useFontMetrics.ios.ts
Nov 19, 2022
eda4c62
Remove useFontMetricsScaleFactors warning on non-iOS platforms
Nov 21, 2022
2d46157
Move fontMetrics accesses outside of continuation, and improve typing
Nov 22, 2022
ce812bc
Fix Text rerender shallow equality test
Nov 22, 2022
1bfe8a5
Handle case when NativeFontMetrics isn't defined
Nov 22, 2022
3741063
IFontMetrics -> FontMetrics
Nov 22, 2022
88a099d
Keep `mergedProps` spreads next to each other
Nov 28, 2022
7871a01
Merge branch 'main' into furn-font-metrics
Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unneeded API
  • Loading branch information
Adam Gleitman committed Nov 3, 2022
commit cbcff5ac0e2e15cd026e7f3e7a45e9641347352a
5 changes: 0 additions & 5 deletions packages/experimental/NativeFontMetrics/ios/FRNFontMetrics.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,6 @@ + (BOOL)requiresMainQueueSetup
return result;
}

RCT_EXPORT_METHOD(calculateScaleFactorForStyle:(NSString *)style callback:(RCTResponseSenderBlock)callback)
{
callback(@[[self scaleFactorForStyle:style]]);
}

RCT_EXPORT_BLOCKING_SYNCHRONOUS_METHOD(scaleFactorForStyle:(NSString *)styleString)
{
FRNTextStyle style = [RCTConvert FRNTextStyle:styleString];
Expand Down
1 change: 0 additions & 1 deletion packages/experimental/NativeFontMetrics/src/NativeFontMetrics.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ export type ScaleFactors = { [K in TextStyle]: number | undefined };

interface NativeFontMetricsInterface {
allScaleFactors(): ScaleFactors;
calculateScaleFactorForStyle(style: TextStyle, callback: (number) => void);
scaleFactorForStyle(style: TextStyle): number;
}
export default NativeFontMetrics as NativeFontMetricsInterface;