Skip to content

Dropdown: do not select first option automatically unless using keyboard navigation (backport of #10755)#10866

Merged
joschect merged 1 commit into
microsoft:6.0from
pKalaga:prkalaga/6.0
Oct 17, 2019
Merged

Dropdown: do not select first option automatically unless using keyboard navigation (backport of #10755)#10866
joschect merged 1 commit into
microsoft:6.0from
pKalaga:prkalaga/6.0

Conversation

@pKalaga

@pKalaga pKalaga commented Oct 16, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

backport of PR : #10755
please refer the parent for details

Pull request checklist

Description of changes

In case of keyboard navigation to dropdown, per aria guidance, dropdown should select first option by default on focus. But we do not want to do this if user clicked and opened the dropdown.

Microsoft Reviewers: Open in CodeFlow

@xugao @pKalaga
Dropdown: do not select first option automatically
ff7eb83 
unless it's selected using keyboard navigation (microsoft#10755)

* do not select first option by default for non-aria case
* update snapshots
* code cleanup
* yarn change
* add Aria doc link inline
* simplify to use one class vars rather than two
@pKalaga
pKalaga requested a review from joschect as a code owner October 16, 2019 08:14
@pKalaga pKalaga changed the title Dropdown: do not select first option automatically unless it's selected using keyboard navigation (#10755) Dropdown: do not select first option automatically unless it's selected using keyboard navigation ( backport of #10755) Oct 16, 2019
@pKalaga pKalaga changed the title Dropdown: do not select first option automatically unless it's selected using keyboard navigation ( backport of #10755) Dropdown: do not select first option automatically unless using keyboard navigation ( backport of #10755) Oct 16, 2019
@pKalaga pKalaga changed the title Dropdown: do not select first option automatically unless using keyboard navigation ( backport of #10755) Dropdown: do not select first option automatically unless using keyboard navigation (backport of #10755) Oct 16, 2019
@size-auditor

size-auditor Bot commented Oct 16, 2019 •
edited
Loading

Copy link
Copy Markdown

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react Dropdown 206.341 kB 206.622 kB ExceedsBaseline     281 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 6a14b4509ce477f38ae05856f19bad198374d08d (build)

@pKalaga

pKalaga commented Oct 16, 2019

Copy link
Copy Markdown
Contributor Author

@ecraig12345 @dzearing
similar to the parent PR, the failing screener tests are expected and valid regressions - can someone take a look and approve them?

joschect
joschect previously approved these changes Oct 16, 2019
View reviewed changes
@joschect
joschect dismissed their stale review October 16, 2019 17:18

Need to look at screener first

@joschect joschect closed this Oct 16, 2019
@joschect joschect reopened this Oct 16, 2019
@xugao
xugao self-requested a review October 17, 2019 00:00
@joschect joschect closed this Oct 17, 2019
@joschect

joschect commented Oct 17, 2019

Copy link
Copy Markdown
Contributor

Reopening to trigger new build

@joschect joschect reopened this Oct 17, 2019
@joschect
joschect merged commit aca21fa into microsoft:6.0 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@xugao xugao xugao approved these changes
@joschect joschect joschect approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ecraig12345 ecraig12345

Labels

Component: Dropdown Fabric 6

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pKalaga @joschect @xugao @ecraig12345 @msft-github-bot