Skip to content

DetailsList: Adding Announced section for # of filtered items in examples#11512

Merged
msft-github-bot merged 2 commits into
microsoft:masterfrom
khmakoto:detailsListFilterByName
Dec 19, 2019
Merged

DetailsList: Adding Announced section for # of filtered items in examples#11512
msft-github-bot merged 2 commits into
microsoft:masterfrom
khmakoto:detailsListFilterByName

Conversation

@khmakoto

@khmakoto khmakoto commented Dec 18, 2019

Copy link
Copy Markdown
Member

Pull request checklist

Description of changes

This PR adds the Announced component with its message focusing on the number of items in the DetailsList so that when this number changes because of a change in the name filter TextField this information is announced by screen readers.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot

Copy link
Copy Markdown
Contributor

Component Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 853 829
BaseButton (experiments) 1100 1065
DefaultButton 1120 1104
DefaultButton (experiments) 2161 2147
DetailsRow 3537 3514
DetailsRow (fast icons) 3645 3631
DetailsRow without styles 3385 3388
DocumentCardTitle with truncation 34209 34074
MenuButton 1428 1399
MenuButton (experiments) 3787 3767
PrimaryButton 1238 1258
PrimaryButton (experiments) 2194 2227
SplitButton 2964 3060
SplitButton (experiments) 7718 7686
Stack 518 535
Stack with Intrinsic children 1204 1249
Stack with Text children 4592 4646
Text 419 426
Toggle 936 928
Toggle (experiments) 2441 2557
button 68 59

@msft-github-bot

Copy link
Copy Markdown
Contributor

Hello @khmakoto!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@msft-github-bot
msft-github-bot merged commit 2db422c into microsoft:master Dec 19, 2019
@khmakoto
khmakoto deleted the detailsListFilterByName branch December 19, 2019 07:05
@msft-github-bot

Copy link
Copy Markdown
Contributor

🎉office-ui-fabric-react@v7.75.0 has been released which incorporates this pull request.:tada:

Handy links:

@TestAccessibilityGIT TestAccessibilityGIT mentioned this pull request Dec 19, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants