Skip to content

DetailsList: Adding Announced section for examples that have '# of items selected' message in display#11513

Merged
msft-github-bot merged 3 commits into
microsoft:masterfrom
khmakoto:detailsListSelectedCount
Dec 19, 2019
Merged

DetailsList: Adding Announced section for examples that have '# of items selected' message in display#11513
msft-github-bot merged 3 commits into
microsoft:masterfrom
khmakoto:detailsListSelectedCount

Conversation

@khmakoto

@khmakoto khmakoto commented Dec 18, 2019

Copy link
Copy Markdown
Member

Pull request checklist

Description of changes

This PR adds an Announced component to examples that have a selected file counts section that dynamically updates so that this information is also relayed via screen readers.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot

msft-github-bot commented Dec 19, 2019

Copy link
Copy Markdown
Contributor

Component Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 758 756
BaseButton (experiments) 995 992
DefaultButton 1024 1013
DefaultButton (experiments) 1966 1933
DetailsRow 3257 3242
DetailsRow (fast icons) 3345 3304
DetailsRow without styles 3096 3076
DocumentCardTitle with truncation 31499 31452
MenuButton 1321 1311
MenuButton (experiments) 3506 3538
PrimaryButton 1193 1249
PrimaryButton (experiments) 2017 2010
SplitButton 2843 2733
SplitButton (experiments) 7068 6978
Stack 481 486
Stack with Intrinsic children 1092 1106
Stack with Text children 4246 4332
Text 381 362
Toggle 816 844
Toggle (experiments) 2292 2266
button 59 55

@khmakoto khmakoto closed this Dec 19, 2019
@khmakoto khmakoto reopened this Dec 19, 2019
@msft-github-bot

Copy link
Copy Markdown
Contributor

Hello @khmakoto!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@msft-github-bot
msft-github-bot merged commit e8b2620 into microsoft:master Dec 19, 2019
@khmakoto
khmakoto deleted the detailsListSelectedCount branch December 19, 2019 08:13
@msft-github-bot

Copy link
Copy Markdown
Contributor

🎉office-ui-fabric-react@v7.75.0 has been released which incorporates this pull request.:tada:

Handy links:

@TestAccessibilityGIT TestAccessibilityGIT mentioned this pull request Dec 19, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants