feat(storybook): Hide internal stories, add internal stories and E2E tests for Menu#18627
Closed
ling1726 wants to merge 15 commits into
Closed
feat(storybook): Hide internal stories, add internal stories and E2E tests for Menu#18627ling1726 wants to merge 15 commits into
ling1726 wants to merge 15 commits into
Conversation
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1706b9cd5b28d63b015f0a296059456465a1edd6 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 962 | 940 | 5000 | |
| BaseButton | mount | 1034 | 1008 | 5000 | |
| Breadcrumb | mount | 2665 | 2828 | 1000 | |
| ButtonNext | mount | 469 | 447 | 5000 | |
| Checkbox | mount | 1656 | 1620 | 5000 | |
| CheckboxBase | mount | 1349 | 1431 | 5000 | |
| ChoiceGroup | mount | 5405 | 5137 | 5000 | |
| ComboBox | mount | 1076 | 1088 | 1000 | |
| CommandBar | mount | 10800 | 10757 | 1000 | |
| ContextualMenu | mount | 6521 | 6508 | 1000 | |
| DefaultButton | mount | 1251 | 1242 | 5000 | |
| DetailsRow | mount | 4047 | 4139 | 5000 | |
| DetailsRowFast | mount | 4157 | 4166 | 5000 | |
| DetailsRowNoStyles | mount | 3893 | 3857 | 5000 | |
| Dialog | mount | 2201 | 2219 | 1000 | |
| DocumentCardTitle | mount | 156 | 154 | 1000 | |
| Dropdown | mount | 3465 | 3548 | 5000 | |
| FluentProviderNext | mount | 7379 | 7215 | 5000 | |
| FocusTrapZone | mount | 1954 | 1913 | 5000 | |
| FocusZone | mount | 1946 | 1990 | 5000 | |
| IconButton | mount | 1934 | 1922 | 5000 | |
| Label | mount | 345 | 332 | 5000 | |
| Layer | mount | 1888 | 1911 | 5000 | |
| Link | mount | 501 | 485 | 5000 | |
| MakeStyles | mount | 1854 | 1959 | 50000 | |
| MenuButton | mount | 1598 | 1561 | 5000 | |
| MessageBar | mount | 2155 | 2134 | 5000 | |
| Nav | mount | 3908 | 3492 | 1000 | |
| OverflowSet | mount | 1149 | 1156 | 5000 | |
| Panel | mount | 2234 | 2169 | 1000 | |
| Persona | mount | 882 | 923 | 1000 | |
| Pivot | mount | 1469 | 1460 | 1000 | |
| PrimaryButton | mount | 1439 | 1400 | 5000 | |
| Rating | mount | 8515 | 8637 | 5000 | |
| SearchBox | mount | 1477 | 1458 | 5000 | |
| Shimmer | mount | 2808 | 2813 | 5000 | |
| Slider | mount | 2186 | 2136 | 5000 | |
| SpinButton | mount | 5531 | 5437 | 5000 | |
| Spinner | mount | 449 | 456 | 5000 | |
| SplitButton | mount | 3490 | 3461 | 5000 | |
| Stack | mount | 561 | 576 | 5000 | |
| StackWithIntrinsicChildren | mount | 1767 | 1766 | 5000 | |
| StackWithTextChildren | mount | 5251 | 5295 | 5000 | |
| SwatchColorPicker | mount | 10993 | 10907 | 5000 | |
| Tabs | mount | 1572 | 1597 | 1000 | |
| TagPicker | mount | 2908 | 2898 | 5000 | |
| TeachingBubble | mount | 12529 | 12385 | 5000 | |
| Text | mount | 486 | 484 | 5000 | |
| TextField | mount | 1514 | 1476 | 5000 | |
| ThemeProvider | mount | 1204 | 1285 | 5000 | |
| ThemeProvider | virtual-rerender | 621 | 619 | 5000 | |
| Toggle | mount | 893 | 850 | 5000 | |
| buttonNative | mount | 123 | 130 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| PortalMinimalPerf.default | 187 | 170 | 1.1:1 |
| ChatWithPopoverPerf.default | 406 | 373 | 1.09:1 |
| ChatMinimalPerf.default | 742 | 688 | 1.08:1 |
| HeaderMinimalPerf.default | 422 | 392 | 1.08:1 |
| LayoutMinimalPerf.default | 417 | 387 | 1.08:1 |
| RefMinimalPerf.default | 257 | 238 | 1.08:1 |
| AvatarMinimalPerf.default | 228 | 213 | 1.07:1 |
| ListWith60ListItems.default | 718 | 668 | 1.07:1 |
| ReactionMinimalPerf.default | 435 | 405 | 1.07:1 |
| TableManyItemsPerf.default | 2193 | 2076 | 1.06:1 |
| AttachmentMinimalPerf.default | 176 | 168 | 1.05:1 |
| CardMinimalPerf.default | 636 | 603 | 1.05:1 |
| DividerMinimalPerf.default | 409 | 390 | 1.05:1 |
| RadioGroupMinimalPerf.default | 513 | 490 | 1.05:1 |
| ToolbarMinimalPerf.default | 1056 | 1005 | 1.05:1 |
| TreeWith60ListItems.default | 202 | 193 | 1.05:1 |
| HeaderSlotsPerf.default | 869 | 835 | 1.04:1 |
| ImageMinimalPerf.default | 443 | 427 | 1.04:1 |
| ListNestedPerf.default | 614 | 588 | 1.04:1 |
| IconMinimalPerf.default | 703 | 678 | 1.04:1 |
| AnimationMinimalPerf.default | 437 | 425 | 1.03:1 |
| CarouselMinimalPerf.default | 541 | 523 | 1.03:1 |
| EmbedMinimalPerf.default | 4637 | 4496 | 1.03:1 |
| FlexMinimalPerf.default | 319 | 309 | 1.03:1 |
| FormMinimalPerf.default | 479 | 465 | 1.03:1 |
| LabelMinimalPerf.default | 442 | 428 | 1.03:1 |
| ListCommonPerf.default | 707 | 689 | 1.03:1 |
| SkeletonMinimalPerf.default | 402 | 392 | 1.03:1 |
| BoxMinimalPerf.default | 386 | 379 | 1.02:1 |
| ButtonSlotsPerf.default | 604 | 594 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 1362 | 1340 | 1.02:1 |
| ProviderMinimalPerf.default | 1112 | 1095 | 1.02:1 |
| SegmentMinimalPerf.default | 376 | 367 | 1.02:1 |
| SplitButtonMinimalPerf.default | 4339 | 4243 | 1.02:1 |
| TreeMinimalPerf.default | 893 | 877 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 317 | 315 | 1.01:1 |
| DropdownMinimalPerf.default | 3302 | 3263 | 1.01:1 |
| GridMinimalPerf.default | 376 | 374 | 1.01:1 |
| MenuMinimalPerf.default | 913 | 900 | 1.01:1 |
| VideoMinimalPerf.default | 737 | 730 | 1.01:1 |
| AttachmentSlotsPerf.default | 1155 | 1158 | 1:1 |
| ButtonOverridesMissPerf.default | 1820 | 1829 | 1:1 |
| DatepickerMinimalPerf.default | 5878 | 5899 | 1:1 |
| DropdownManyItemsPerf.default | 798 | 795 | 1:1 |
| ListMinimalPerf.default | 559 | 561 | 1:1 |
| SliderMinimalPerf.default | 1700 | 1704 | 1:1 |
| StatusMinimalPerf.default | 776 | 778 | 1:1 |
| TableMinimalPerf.default | 445 | 443 | 1:1 |
| TooltipMinimalPerf.default | 1115 | 1115 | 1:1 |
| AccordionMinimalPerf.default | 155 | 157 | 0.99:1 |
| CheckboxMinimalPerf.default | 2928 | 2947 | 0.99:1 |
| DialogMinimalPerf.default | 828 | 834 | 0.99:1 |
| MenuButtonMinimalPerf.default | 1741 | 1761 | 0.99:1 |
| CustomToolbarPrototype.default | 4144 | 4170 | 0.99:1 |
| LoaderMinimalPerf.default | 705 | 718 | 0.98:1 |
| RosterPerf.default | 1289 | 1311 | 0.98:1 |
| AlertMinimalPerf.default | 311 | 320 | 0.97:1 |
| InputMinimalPerf.default | 1321 | 1359 | 0.97:1 |
| ProviderMergeThemesPerf.default | 1693 | 1746 | 0.97:1 |
| PopupMinimalPerf.default | 605 | 628 | 0.96:1 |
| TextAreaMinimalPerf.default | 560 | 586 | 0.96:1 |
| ButtonMinimalPerf.default | 184 | 193 | 0.95:1 |
| TextMinimalPerf.default | 359 | 381 | 0.94:1 |
ling1726
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c62b2e4:
|
2 tasks
Hotell
reviewed
Aug 6, 2021
| Storybook will eventually release this feature | ||
| https://github.com/storybookjs/storybook/issues/9209 | ||
|
|
||
| Can moved from here to @fluentui/react-components after colocated storybook migration |
Contributor
There was a problem hiding this comment.
can we track this via issue pls ?
Collaborator
📊 Bundle size reportUnchanged fixtures
|
ling1726
changed the title
ling1726
marked this pull request as ready for review
August 13, 2021 14:35
Contributor
|
can this be merged or closed ? it has been open for 6 months. thx |
Contributor
Author
I'll close it, and roll out another PR later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
Creates a workflow for internal stories. This PR:
Internalas a keyword in our story naming conventioninternalkeywork in the story idMenuFocus areas to test
(optional)