PeoplePicker: Styling, accessibility, and perf bug fixes.#1938
Merged
dzearing merged 5 commits intoJun 14, 2017
Conversation
added 5 commits
June 2, 2017 15:21
…eight of the container for better veritcal centering.
kristoferbrown
requested review from
dzearing,
gokunymbus,
joschect,
micahgodbolt and
mikewheaton
June 5, 2017 23:08
dzearing
approved these changes
Jun 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Persona: Replaced padding and line height values with flex column
Selected people picker pill items: made pills variable width, removed ability to focus on X button, added unique keys to prevent excessive rerenders, made focus zone bidirectional and circular.
People picker suggestion list: added unique keys to suggestions to prevent excessive rerenders, made picker able to tell when up/down keys should move focus zone or select suggestions, suggestion list no longer overlaps input well.
Focus areas to test
People picker, Persona