chore(eslint, conformance): Use `*` versions for dev dependencies by ling1726 · Pull Request #19848 · microsoft/fluentui

ling1726 · 2021-09-17T10:06:01Z

Pull request checklist

Addresses an existing issue: Fixes partially react-components versioning and release cycle #19106
Include a change request file using $ yarn change

Description of changes

Following #19799, runs the generator and migrates all packages in the
monorepo to use esling-plugin and react-conformance with * version in dev dependencies.

This avoids potential version bumping issues when Fluent vNext is released separately to the rest of the repo

Following microsoft#19799, runs the generator and migrates all packages in the monorepo to use `esling-plugin` and `react-conformance` as dev dependencies

codesandbox-ci · 2021-09-17T10:14:28Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 06d94ef:

Sandbox	Source
Fluent UI React Starter	Configuration

size-auditor · 2021-09-17T10:16:57Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8e7bdc56f478a572a2e6d7636a528c65b9df8bb7 (build)

fabricteam · 2021-09-17T10:24:31Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`react-accordion` Accordion (including children components)	`55.248 kB` `17.403 kB`
`react-avatar` Avatar	`56.558 kB` `15.66 kB`
`react-badge` Badge	`24.343 kB` `7.165 kB`
`react-badge` CounterBadge	`27.156 kB` `7.851 kB`
`react-badge` PresenseBadge	`237 B` `177 B`
`react-button` Button	`22.932 kB` `6.984 kB`
`react-button` CompoundButton	`28.215 kB` `7.834 kB`
`react-button` MenuButton	`24.733 kB` `7.546 kB`
`react-button` ToggleButton	`32.527 kB` `7.601 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`164.374 kB` `46.901 kB`
`react-components` react-components: FluentProvider & webLightTheme	`35.75 kB` `11.392 kB`
`react-divider` Divider	`15.889 kB` `5.747 kB`
`react-image` Image	`9.882 kB` `3.975 kB`
`react-input` Input	`31.636 kB` `11.312 kB`
`react-label` Label	`9.397 kB` `3.839 kB`
`react-link` Link	`13.718 kB` `5.66 kB`
`react-make-styles` makeStaticStyles (runtime)	`7.59 kB` `3.321 kB`
`react-make-styles` makeStyles + mergeClasses (runtime)	`22.135 kB` `8.356 kB`
`react-make-styles` makeStyles + mergeClasses (build time)	`2.557 kB` `1.202 kB`
`react-menu` Menu (including children components)	`103.402 kB` `31.415 kB`
`react-menu` Menu (including selectable components)	`105.678 kB` `31.769 kB`
`react-popover` Popover	`100.411 kB` `30.075 kB`
`react-portal` Portal	`6.725 kB` `2.237 kB`
`react-positioning` usePopper	`23.145 kB` `7.942 kB`
`react-provider` FluentProvider	`15.748 kB` `5.773 kB`
`react-slider` Slider	`30.697 kB` `9.75 kB`
`react-switch` Switch	`18.067 kB` `6.181 kB`
`react-text` Text - Default	`11.798 kB` `4.452 kB`
`react-text` Text - Wrappers	`15.414 kB` `4.734 kB`
`react-theme` Teams: all themes	`32.941 kB` `6.674 kB`
`react-theme` Teams: Light theme	`20.247 kB` `5.662 kB`
`react-tooltip` Tooltip	`46.016 kB` `15.656 kB`
`react-utilities` SSRProvider	`213 B` `170 B`

_{🤖 This report was generated against 8e7bdc56f478a572a2e6d7636a528c65b9df8bb7}

fabricteam · 2021-09-17T10:35:45Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	961	950	5000
BaseButton	mount	978	949	5000
Breadcrumb	mount	2704	2691	1000
ButtonNext	mount	482	472	5000
Checkbox	mount	1629	1700	5000
CheckboxBase	mount	1418	1409	5000
ChoiceGroup	mount	5042	5227	5000
ComboBox	mount	1042	1061	1000
CommandBar	mount	10334	10482	1000
ContextualMenu	mount	6781	6671	1000
DefaultButton	mount	1196	1227	5000
DetailsRow	mount	3927	3950	5000
DetailsRowFast	mount	3944	3989	5000
DetailsRowNoStyles	mount	3898	3868	5000
Dialog	mount	2624	2633	1000
DocumentCardTitle	mount	155	167	1000
Dropdown	mount	3603	3661	5000
FluentProviderNext	mount	7090	7456	5000
FluentProviderWithTheme	mount	352	349	10
FluentProviderWithTheme	virtual-rerender	99	91	10
FluentProviderWithTheme	virtual-rerender-with-unmount	480	487	10
FocusTrapZone	mount	1864	1872	5000
FocusZone	mount	1864	1847	5000
IconButton	mount	1906	1907	5000
Label	mount	359	371	5000
Layer	mount	3120	3196	5000
Link	mount	482	499	5000
MakeStyles	mount	1996	1920	50000
MenuButton	mount	1660	1674	5000
MessageBar	mount	2111	2169	5000
Nav	mount	3435	3466	1000
OverflowSet	mount	1142	1147	5000
Panel	mount	1400	2392	1000
Persona	mount	895	867	1000
Pivot	mount	1495	1433	1000
PrimaryButton	mount	1404	1409	5000
Rating	mount	8450	8392	5000
SearchBox	mount	1431	1453	5000
Shimmer	mount	2805	2716	5000
Slider	mount	2053	2083	5000
SpinButton	mount	5253	5307	5000
Spinner	mount	417	419	5000
SplitButton	mount	3362	3345	5000
Stack	mount	543	564	5000
StackWithIntrinsicChildren	mount	1665	1726	5000
StackWithTextChildren	mount	5126	5079	5000
SwatchColorPicker	mount	10839	11073	5000
Tabs	mount	1517	1481	1000
TagPicker	mount	2781	2775	5000
TeachingBubble	mount	13676	13727	5000
Text	mount	463	462	5000
TextField	mount	1455	1535	5000
ThemeProvider	mount	1218	1187	5000
ThemeProvider	virtual-rerender	628	605	5000
ThemeProvider	virtual-rerender-with-unmount	1953	2010	5000
Toggle	mount	845	851	5000
buttonNative	mount	121	114	5000

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ButtonMinimalPerf.default	197	177	1.11:1
AttachmentMinimalPerf.default	188	171	1.1:1
ChatDuplicateMessagesPerf.default	329	306	1.08:1
ImageMinimalPerf.default	451	423	1.07:1
InputMinimalPerf.default	1406	1318	1.07:1
AvatarMinimalPerf.default	211	199	1.06:1
FlexMinimalPerf.default	299	283	1.06:1
MenuButtonMinimalPerf.default	1886	1774	1.06:1
AnimationMinimalPerf.default	454	431	1.05:1
BoxMinimalPerf.default	386	369	1.05:1
ButtonSlotsPerf.default	599	569	1.05:1
CardMinimalPerf.default	626	597	1.05:1
ChatWithPopoverPerf.default	417	398	1.05:1
RefMinimalPerf.default	253	240	1.05:1
SegmentMinimalPerf.default	395	376	1.05:1
IconMinimalPerf.default	703	667	1.05:1
ButtonOverridesMissPerf.default	1842	1776	1.04:1
CarouselMinimalPerf.default	507	487	1.04:1
LabelMinimalPerf.default	430	412	1.04:1
ListMinimalPerf.default	560	539	1.04:1
ListNestedPerf.default	623	599	1.04:1
LoaderMinimalPerf.default	749	718	1.04:1
HeaderSlotsPerf.default	850	829	1.03:1
LayoutMinimalPerf.default	399	386	1.03:1
ListCommonPerf.default	696	674	1.03:1
ProviderMergeThemesPerf.default	1712	1660	1.03:1
SliderMinimalPerf.default	1756	1707	1.03:1
SplitButtonMinimalPerf.default	4666	4533	1.03:1
StatusMinimalPerf.default	754	729	1.03:1
TreeWith60ListItems.default	193	187	1.03:1
AccordionMinimalPerf.default	161	158	1.02:1
DialogMinimalPerf.default	813	800	1.02:1
DividerMinimalPerf.default	399	392	1.02:1
DropdownManyItemsPerf.default	752	739	1.02:1
DropdownMinimalPerf.default	3208	3138	1.02:1
ItemLayoutMinimalPerf.default	1355	1333	1.02:1
TextMinimalPerf.default	377	368	1.02:1
AttachmentSlotsPerf.default	1176	1160	1.01:1
EmbedMinimalPerf.default	4381	4341	1.01:1
MenuMinimalPerf.default	921	912	1.01:1
PopupMinimalPerf.default	622	613	1.01:1
TableManyItemsPerf.default	2056	2045	1.01:1
TableMinimalPerf.default	427	423	1.01:1
ChatMinimalPerf.default	696	693	1:1
DatepickerMinimalPerf.default	5780	5769	1:1
HeaderMinimalPerf.default	391	391	1:1
RadioGroupMinimalPerf.default	489	488	1:1
ReactionMinimalPerf.default	428	427	1:1
CustomToolbarPrototype.default	4032	4049	1:1
AlertMinimalPerf.default	284	286	0.99:1
ProviderMinimalPerf.default	1092	1099	0.99:1
ToolbarMinimalPerf.default	985	996	0.99:1
CheckboxMinimalPerf.default	2855	2899	0.98:1
GridMinimalPerf.default	358	365	0.98:1
ListWith60ListItems.default	675	692	0.98:1
PortalMinimalPerf.default	176	180	0.98:1
TextAreaMinimalPerf.default	535	548	0.98:1
TooltipMinimalPerf.default	1093	1111	0.98:1
TreeMinimalPerf.default	855	869	0.98:1
VideoMinimalPerf.default	657	670	0.98:1
RosterPerf.default	1256	1294	0.97:1
SkeletonMinimalPerf.default	375	397	0.94:1
FormMinimalPerf.default	425	460	0.92:1

…crosoft#19848)

chore(eslint, conformance): Use * versions for dev dependencies

b351227

Following microsoft#19799, runs the generator and migrates all packages in the monorepo to use `esling-plugin` and `react-conformance` as dev dependencies

ling1726 requested review from a team, Jacqueline-ms, Jahnp, JustSlone, Raghurk, behowell, bigbadcapers, czearing, dzearing, ecraig12345, evlevy, hyoshis, jurokapsiar, khmakoto, kolaps33, layershifter, lorejoh12, miroslavstastny and pompomon as code owners September 17, 2021 10:06

msft-fluent-ui-bot assigned GeoffCoxMSFT Sep 17, 2021

Change files

06d94ef

miroslavstastny approved these changes Sep 17, 2021

View reviewed changes

ecraig12345 approved these changes Sep 17, 2021

View reviewed changes

ecraig12345 merged commit 55ed895 into microsoft:master Sep 17, 2021

mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022

chore(eslint, conformance): Use * versions for dev dependencies (mi…

bbeb299

…crosoft#19848)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(eslint, conformance): Use `*` versions for dev dependencies#19848

chore(eslint, conformance): Use `*` versions for dev dependencies#19848
ecraig12345 merged 2 commits into
microsoft:masterfrom
ling1726:chore/star-dev-deps

ling1726 commented Sep 17, 2021 •

edited

Loading

Uh oh!

codesandbox-ci Bot commented Sep 17, 2021

Uh oh!

size-auditor Bot commented Sep 17, 2021

Uh oh!

fabricteam commented Sep 17, 2021

Uh oh!

fabricteam commented Sep 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

ling1726 commented Sep 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request checklist

Description of changes

Uh oh!

codesandbox-ci Bot commented Sep 17, 2021

Uh oh!

size-auditor Bot commented Sep 17, 2021

Asset size changes

Uh oh!

fabricteam commented Sep 17, 2021

📊 Bundle size report

Uh oh!

fabricteam commented Sep 17, 2021

Perf Analysis (@fluentui/react)

Perf Analysis (@fluentui/react-northstar)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ling1726 commented Sep 17, 2021 •

edited

Loading

Perf Analysis (`@fluentui/react`)

Perf Analysis (`@fluentui/react-northstar`)