Skip to content

Remove FocusZone from BasePicker in v7#20204

Closed
mavarsh wants to merge 1 commit into
microsoft:7.0from
mavarsh:users/mavarsh/pickersacc
Closed

Remove FocusZone from BasePicker in v7#20204
mavarsh wants to merge 1 commit into
microsoft:7.0from
mavarsh:users/mavarsh/pickersacc

Conversation

@mavarsh

@mavarsh mavarsh commented Oct 13, 2021

Copy link
Copy Markdown

Pull request checklist

Description of changes

Current implementation was adding a focus zone over a base picker, but if you have a focus zone over a picker then you can't navigate the suggestions using the arrow keys.

Removing the focus zone over the base picker fix the issue. This have been fixed the same way in the latest fluent ui package (#17723).

Focus areas to test

Accessiblity

@mavarsh
mavarsh requested a review from a team as a code owner October 13, 2021 11:36
@msft-fluent-ui-bot msft-fluent-ui-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 13, 2021

@msft-fluent-ui-bot msft-fluent-ui-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this change to the 7.0 branch may not have been submitted to master yet. Now that version 8 has released, all changes must be submitted to the master branch first (except in emergencies or if the change is irrelevant to version 8).

Please do one of the following:

  • If you've already created a PR to master, add a link to it
  • If the change is irrelevant to version 8, add a comment explaining why
  • Otherwise, create a PR to master with this same change, and add a link to it

After that, you can dismiss this review and remove the "needs cherry-pick" label (or ask a team member to help do so).

Want to avoid this in the future? Include text like "Cherry-pick of ####" in the PR description (where #### is the real master PR number).

@ghost

ghost commented Oct 13, 2021

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ mavarsh sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 95cb24d:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@ecraig12345 ecraig12345 changed the title Fixing the suggestions automatically pop ing out using arrow keys Remove FocusZone from BasePicker in v7 Oct 19, 2021
@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 29, 2021
@ecraig12345

Copy link
Copy Markdown
Member

Thanks for the contribution, but unfortunately this change is too high risk/potentially breaking for us to make in version 7 at this point. If you'd like the pickers without a FocusZone, you'll need to upgrade to version 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants