Remove FocusZone from BasePicker in v7#20204
Conversation
msft-fluent-ui-bot
left a comment
There was a problem hiding this comment.
It looks like this change to the 7.0 branch may not have been submitted to master yet. Now that version 8 has released, all changes must be submitted to the master branch first (except in emergencies or if the change is irrelevant to version 8).
Please do one of the following:
- If you've already created a PR to
master, add a link to it - If the change is irrelevant to version 8, add a comment explaining why
- Otherwise, create a PR to
masterwith this same change, and add a link to it
After that, you can dismiss this review and remove the "needs cherry-pick" label (or ask a team member to help do so).
Want to avoid this in the future? Include text like "Cherry-pick of ####" in the PR description (where #### is the real master PR number).
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 95cb24d:
|
|
Thanks for the contribution, but unfortunately this change is too high risk/potentially breaking for us to make in version 7 at this point. If you'd like the pickers without a FocusZone, you'll need to upgrade to version 8. |
Pull request checklist
Description of changes
Current implementation was adding a focus zone over a base picker, but if you have a focus zone over a picker then you can't navigate the suggestions using the arrow keys.
Removing the focus zone over the base picker fix the issue. This have been fixed the same way in the latest fluent ui package (#17723).
Focus areas to test
Accessiblity